Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Issue 1337073002: Refactor DeviceUtils.Install and InstallSplitApk to use the same helper (Closed)

Created:
5 years, 3 months ago by agrieve
Modified:
5 years, 3 months ago
Reviewers:
Dmitry Skiba, jbudorick
CC:
chromium-reviews, jbudorick+watch_chromium.org, klundberg+watch_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactor DeviceUtils.Install and InstallSplitApk to use the same helper Motivated by Install() getting a new permissions attribute without InstallSplitApk() being updated (http://crrev.com/de468d72d9e) There is also a sematic change: - When a previous install is present and reinstall=False, we used to check if the install on-device was identical and no-op in this case. Now, we do an uninstall + install regardless of whether the on-device version is identical. This new behaviour is more correct since it guarantees that no stale data will be present when reinstall=False. BUG= Committed: https://crrev.com/307cf30fea5e791de2ebac395b1d9a154afc637b Cr-Commit-Position: refs/heads/master@{#348419}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -56 lines) Patch
M build/android/devil/android/device_utils.py View 3 chunks +53 lines, -45 lines 0 comments Download
M build/android/devil/android/device_utils_test.py View 6 chunks +10 lines, -11 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (3 generated)
agrieve
5 years, 3 months ago (2015-09-11 15:20:41 UTC) #2
jbudorick
lgtm
5 years, 3 months ago (2015-09-11 15:26:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1337073002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1337073002/1
5 years, 3 months ago (2015-09-11 16:47:30 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-11 17:30:32 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/307cf30fea5e791de2ebac395b1d9a154afc637b Cr-Commit-Position: refs/heads/master@{#348419}
5 years, 3 months ago (2015-09-11 17:31:12 UTC) #7
Dmitry Skiba
With this change consecutive invocations of "adb_install_apk.py --apk Chrome.apk --release" always reinstall the app, while ...
5 years, 3 months ago (2015-09-14 21:36:39 UTC) #9
jbudorick
On 2015/09/14 at 21:36:39, dskiba wrote: > With this change consecutive invocations of "adb_install_apk.py --apk ...
5 years, 3 months ago (2015-09-14 22:11:45 UTC) #10
Dmitry Skiba
On 2015/09/14 22:11:45, jbudorick wrote: > On 2015/09/14 at 21:36:39, dskiba wrote: > > With ...
5 years, 3 months ago (2015-09-14 22:40:37 UTC) #11
agrieve
On 2015/09/14 22:40:37, Dmitry Skiba wrote: > On 2015/09/14 22:11:45, jbudorick wrote: > > On ...
5 years, 3 months ago (2015-09-15 00:48:06 UTC) #12
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:23:27 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/307cf30fea5e791de2ebac395b1d9a154afc637b
Cr-Commit-Position: refs/heads/master@{#348419}

Powered by Google App Engine
This is Rietveld 408576698