Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 1361713003: Reland of Make use of md5_check within process_resources.py (Closed)

Created:
5 years, 2 months ago by agrieve
Modified:
5 years, 2 months ago
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@md5-check-1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Make use of md5_check within process_resources.py (patchset #1 id:1 of https://codereview.chromium.org/1370643002/ ) Reason for revert: Fixed --proguard-file being marked as an input when it's and output. Ensured "all" builds locally. Original issue's description: > Revert of Make use of md5_check within process_resources.py (patchset #4 id:60001 of https://codereview.chromium.org/1357663002/ ) > > Reason for revert: > breaks compilation, e.g. https://build.chromium.org/p/chromium/builders/Android/builds/46769/steps/compile/logs/stdio > > Original issue's description: > > Make use of md5_check within process_resources.py > > > > This stops process_resources being run unnecessarily when only java source files > > have changed. > > > > BUG=533442 > > > > Committed: https://crrev.com/03f85b7b1ff4f61a76630995709257968d8d7eed > > Cr-Commit-Position: refs/heads/master@{#350777} > > TBR=pkotwicz@chromium.org,agrieve@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=533442 > > Committed: https://crrev.com/c5cdc35062bd6b16922074b2d8c5c1f8fc905b9c > Cr-Commit-Position: refs/heads/master@{#350779} TBR=pkotwicz@chromium.org,jochen@chromium.org BUG=533442 Committed: https://crrev.com/8a7df3af2f8571d0d9ec0add67e83f5f539ebd25 Cr-Commit-Position: refs/heads/master@{#350840}

Patch Set 1 #

Patch Set 2 : Fix breakage #

Patch Set 3 : fix failure when R.txt doesn't exists #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -21 lines) Patch
M build/android/gyp/process_resources.py View 1 2 8 chunks +68 lines, -21 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 5 (1 generated)
agrieve
Created Reland of Make use of md5_check within process_resources.py
5 years, 2 months ago (2015-09-25 14:37:15 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1361713003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1361713003/60001
5 years, 2 months ago (2015-09-25 14:55:58 UTC) #3
commit-bot: I haz the power
Committed patchset #3 (id:60001)
5 years, 2 months ago (2015-09-25 16:11:16 UTC) #4
commit-bot: I haz the power
5 years, 2 months ago (2015-09-25 16:11:55 UTC) #5
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/8a7df3af2f8571d0d9ec0add67e83f5f539ebd25
Cr-Commit-Position: refs/heads/master@{#350840}

Powered by Google App Engine
This is Rietveld 408576698