Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1416953004: GN(Android): Fix up media_unittests to match GYP (Closed)

Created:
5 years, 2 months ago by agrieve
Modified:
5 years, 2 months ago
Reviewers:
pkotwicz, brettw
CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org, avayvod+watch_chromium.org, mcasas+watch_chromium.org, mlamouri+watch-media_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN(Android): Fix up media_unittests to match GYP BUG=510485 Committed: https://crrev.com/952116520929d0bf481e064a7d2568aa147a88b8 Cr-Commit-Position: refs/heads/master@{#355715}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M media/BUILD.gn View 1 chunk +5 lines, -5 lines 0 comments Download
M media/audio/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M media/base/android/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Depends on Patchset:

Issue 1217063002 Patch 1

Messages

Total messages: 8 (2 generated)
agrieve
5 years, 2 months ago (2015-10-22 15:20:31 UTC) #2
pkotwicz
lgtm
5 years, 2 months ago (2015-10-22 16:44:25 UTC) #3
brettw
lgtm
5 years, 2 months ago (2015-10-22 23:55:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1416953004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1416953004/1
5 years, 2 months ago (2015-10-23 02:24:43 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-23 02:58:39 UTC) #7
commit-bot: I haz the power
5 years, 2 months ago (2015-10-23 02:59:31 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/952116520929d0bf481e064a7d2568aa147a88b8
Cr-Commit-Position: refs/heads/master@{#355715}

Powered by Google App Engine
This is Rietveld 408576698