Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1339683002: DeviceUtils: Fix crash when creating error message for a non-userdebugdevice (Closed)

Created:
5 years, 3 months ago by agrieve
Modified:
5 years, 3 months ago
Reviewers:
jbudorick
CC:
chromium-reviews, jbudorick+watch_chromium.org, klundberg+watch_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DeviceUtils: Fix crash when creating error message for a non-userdebugdevice BUG= Committed: https://crrev.com/76ba5bfcf815b6710381b549436d3272fb3565b2 Cr-Commit-Position: refs/heads/master@{#348450}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/android/pylib/device/commands/install_commands.py View 1 chunk +1 line, -1 line 1 comment Download

Depends on Patchset:

Issue 1217063002 Patch 1

Messages

Total messages: 12 (4 generated)
agrieve
5 years, 3 months ago (2015-09-11 15:32:18 UTC) #2
jbudorick
lgtm https://codereview.chromium.org/1339683002/diff/1/build/android/pylib/device/commands/install_commands.py File build/android/pylib/device/commands/install_commands.py (right): https://codereview.chromium.org/1339683002/diff/1/build/android/pylib/device/commands/install_commands.py#newcode36 build/android/pylib/device/commands/install_commands.py:36: device_serial=device.adb.GetDeviceSerial()) uh... er... how did this get here
5 years, 3 months ago (2015-09-11 15:34:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1339683002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1339683002/1
5 years, 3 months ago (2015-09-11 15:55:53 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/105959)
5 years, 3 months ago (2015-09-11 17:32:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1339683002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1339683002/1
5 years, 3 months ago (2015-09-11 17:38:49 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-11 18:47:27 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/76ba5bfcf815b6710381b549436d3272fb3565b2 Cr-Commit-Position: refs/heads/master@{#348450}
5 years, 3 months ago (2015-09-11 18:48:13 UTC) #11
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:24:48 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/76ba5bfcf815b6710381b549436d3272fb3565b2
Cr-Commit-Position: refs/heads/master@{#348450}

Powered by Google App Engine
This is Rietveld 408576698