Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 1386353005: DeviceUtils: Write checksums to cache even when not reading them (Closed)

Created:
5 years, 2 months ago by agrieve
Modified:
5 years, 2 months ago
Reviewers:
jbudorick
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DeviceUtils: Write checksums to cache even when not reading them This allows clients to use DumpCacheData() even when enable_device_files_cache=False. Useful for when enable_device_files_cache is set by a flag (so that it doesn't require two runs to be effective) BUG=540857 Committed: https://crrev.com/ed679db4616176ad6245f2bc71be2b068ff01127 Cr-Commit-Position: refs/heads/master@{#353066}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -5 lines) Patch
M build/android/devil/android/device_utils.py View 2 chunks +2 lines, -5 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (4 generated)
agrieve
5 years, 2 months ago (2015-10-08 01:20:22 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1386353005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1386353005/1
5 years, 2 months ago (2015-10-08 01:21:37 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-08 02:26:23 UTC) #6
jbudorick
lgtm
5 years, 2 months ago (2015-10-08 14:28:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1386353005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1386353005/1
5 years, 2 months ago (2015-10-08 15:47:06 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-08 15:53:10 UTC) #10
commit-bot: I haz the power
5 years, 2 months ago (2015-10-08 15:54:04 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ed679db4616176ad6245f2bc71be2b068ff01127
Cr-Commit-Position: refs/heads/master@{#353066}

Powered by Google App Engine
This is Rietveld 408576698