Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(718)

Issue 1459083004: Fix native_lib_placeholders gn gen errors in the presense of splits (Closed)

Created:
5 years, 1 month ago by agrieve
Modified:
5 years, 1 month ago
Reviewers:
pkotwicz
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix native_lib_placeholders gn gen errors in the presence of splits BUG=535390 Committed: https://crrev.com/7646e88523642d558742f387c83c775d72b74e5a Cr-Commit-Position: refs/heads/master@{#360827}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -6 lines) Patch
M build/config/android/rules.gni View 5 chunks +10 lines, -6 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (6 generated)
agrieve
On 2015/11/19 21:41:29, agrieve wrote: > mailto:agrieve@chromium.org changed reviewers: > + mailto:pkotwicz@chromium.org {o,o}
5 years, 1 month ago (2015-11-19 21:41:40 UTC) #3
pkotwicz
lgtm
5 years, 1 month ago (2015-11-19 21:45:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1459083004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1459083004/1
5 years, 1 month ago (2015-11-20 00:48:46 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL) ios_rel_device_ninja on ...
5 years, 1 month ago (2015-11-20 02:54:25 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1459083004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1459083004/1
5 years, 1 month ago (2015-11-20 15:49:32 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-20 15:54:13 UTC) #12
commit-bot: I haz the power
5 years, 1 month ago (2015-11-20 15:54:54 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7646e88523642d558742f387c83c775d72b74e5a
Cr-Commit-Position: refs/heads/master@{#360827}

Powered by Google App Engine
This is Rietveld 408576698