Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1374303004: Make adb_gdb work for GN builds (Closed)

Created:
5 years, 2 months ago by agrieve
Modified:
5 years, 2 months ago
Reviewers:
Yaron
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make adb_gdb work for GN builds Just needed to tell it where to find the libraries. BUG= Committed: https://crrev.com/2381247b86e77aa56ba08174e658a63079f8b61b Cr-Commit-Position: refs/heads/master@{#351471}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -4 lines) Patch
M build/android/BUILD.gn View 1 chunk +16 lines, -1 line 0 comments Download
M build/android/adb_gdb View 1 chunk +5 lines, -3 lines 0 comments Download

Depends on Patchset:

Issue 1217063002 Patch 1

Messages

Total messages: 7 (2 generated)
agrieve
On 2015/09/29 19:40:27, agrieve wrote: > mailto:agrieve@chromium.org changed reviewers: > + mailto:yfriedman@chromium.org ♬
5 years, 2 months ago (2015-09-29 19:40:45 UTC) #2
Yaron
lgtm
5 years, 2 months ago (2015-09-29 21:21:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1374303004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1374303004/1
5 years, 2 months ago (2015-09-30 01:34:53 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-30 02:06:16 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-09-30 02:07:07 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/2381247b86e77aa56ba08174e658a63079f8b61b
Cr-Commit-Position: refs/heads/master@{#351471}

Powered by Google App Engine
This is Rietveld 408576698