Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 1385893004: GN incremental_install: Enable lib copying for all devices (Closed)

Created:
5 years, 2 months ago by agrieve
Modified:
5 years, 2 months ago
Reviewers:
pkotwicz
CC:
chromium-reviews, asanka, benjhayden+dwatch_chromium.org, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN incremental_install: Enable lib copying for all devices Some non-M devices seem to need it BUG=520082 Committed: https://crrev.com/31978e66f0c2ae00926292b37ce61bb19827836c Cr-Commit-Position: refs/heads/master@{#352486}

Patch Set 1 #

Patch Set 2 : tweak what is split up #

Total comments: 2

Patch Set 3 : comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -23 lines) Patch
M build/android/incremental_install/java/org/chromium/incrementalinstall/BootstrapApplication.java View 1 chunk +3 lines, -3 lines 0 comments Download
M build/android/incremental_install/java/org/chromium/incrementalinstall/ClassLoaderPatcher.java View 1 2 3 chunks +16 lines, -20 lines 0 comments Download
M build/android/incremental_install/java/org/chromium/incrementalinstall/LockFile.java View 1 chunk +1 line, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (4 generated)
pkotwicz
https://codereview.chromium.org/1385893004/diff/20001/build/android/incremental_install/java/org/chromium/incrementalinstall/LockFile.java File build/android/incremental_install/java/org/chromium/incrementalinstall/LockFile.java (right): https://codereview.chromium.org/1385893004/diff/20001/build/android/incremental_install/java/org/chromium/incrementalinstall/LockFile.java#newcode102 build/android/incremental_install/java/org/chromium/incrementalinstall/LockFile.java:102: Log.w(TAG, "Exception trying to acquire lock " + file, ...
5 years, 2 months ago (2015-10-05 19:43:19 UTC) #2
agrieve
https://codereview.chromium.org/1385893004/diff/20001/build/android/incremental_install/java/org/chromium/incrementalinstall/LockFile.java File build/android/incremental_install/java/org/chromium/incrementalinstall/LockFile.java (right): https://codereview.chromium.org/1385893004/diff/20001/build/android/incremental_install/java/org/chromium/incrementalinstall/LockFile.java#newcode102 build/android/incremental_install/java/org/chromium/incrementalinstall/LockFile.java:102: Log.w(TAG, "Exception trying to acquire lock " + file, ...
5 years, 2 months ago (2015-10-05 19:46:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1385893004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1385893004/40001
5 years, 2 months ago (2015-10-05 20:29:10 UTC) #5
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 2 months ago (2015-10-05 20:29:11 UTC) #7
pkotwicz
lgtm
5 years, 2 months ago (2015-10-06 00:14:04 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1385893004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1385893004/40001
5 years, 2 months ago (2015-10-06 00:15:18 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 2 months ago (2015-10-06 00:37:41 UTC) #11
commit-bot: I haz the power
5 years, 2 months ago (2015-10-06 00:39:41 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/31978e66f0c2ae00926292b37ce61bb19827836c
Cr-Commit-Position: refs/heads/master@{#352486}

Powered by Google App Engine
This is Rietveld 408576698