Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 1410643013: GN: Fix references to $root_build_dir/natives_blob.bin -> $root_out_dir (Closed)

Created:
5 years, 2 months ago by agrieve
Modified:
5 years, 2 months ago
Reviewers:
pkotwicz, brettw
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, mkwst+moarreviews-shell_chromium.org, jam, jochen+watch_chromium.org, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN: Fix references to $root_build_dir/natives_blob.bin -> $root_out_dir root_build_dir == root_out_dir in all of these contexts anyways, but this is more correct. BUG= Committed: https://crrev.com/b37b712135a1fadf419b6f6145301c545812437a Cr-Commit-Position: refs/heads/master@{#355725}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -13 lines) Patch
M chrome/android/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M components/html_viewer/BUILD.gn View 3 chunks +6 lines, -6 lines 0 comments Download
M content/shell/android/BUILD.gn View 2 chunks +5 lines, -3 lines 0 comments Download
M gin/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 9 (4 generated)
agrieve
5 years, 2 months ago (2015-10-23 02:24:45 UTC) #2
brettw
lgtm
5 years, 2 months ago (2015-10-23 02:31:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1410643013/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1410643013/1
5 years, 2 months ago (2015-10-23 03:26:40 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-23 03:53:52 UTC) #8
commit-bot: I haz the power
5 years, 2 months ago (2015-10-23 03:54:32 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b37b712135a1fadf419b6f6145301c545812437a
Cr-Commit-Position: refs/heads/master@{#355725}

Powered by Google App Engine
This is Rietveld 408576698