Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(553)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1233313003: GN (android): Fix md5sum_bin_host not working for component builds (Closed)

Created:
5 years, 5 months ago by agrieve
Modified:
5 years, 5 months ago
Reviewers:
brettw
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN (android): Fix md5sum_bin_host not working for component builds This affected all test_runner.py invokations. BUG=510442 Committed: https://crrev.com/6cc97ff4e7c37054de5931e2ce07fb469766d204 Cr-Commit-Position: refs/heads/master@{#338898}

Patch Set 1 #

Total comments: 2

Patch Set 2 : improve comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -5 lines) Patch
M build/symlink.py View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/android/md5sum/BUILD.gn View 1 2 chunks +13 lines, -5 lines 0 comments Download

Depends on Patchset:

Issue 1217063002 Patch 1

Messages

Total messages: 9 (2 generated)
agrieve
At first just tried to figure out how to force it to always build with ...
5 years, 5 months ago (2015-07-15 16:58:51 UTC) #2
brettw
https://codereview.chromium.org/1233313003/diff/1/tools/android/md5sum/BUILD.gn File tools/android/md5sum/BUILD.gn (right): https://codereview.chromium.org/1233313003/diff/1/tools/android/md5sum/BUILD.gn#newcode47 tools/android/md5sum/BUILD.gn:47: # Symlink rather than copy so that it still ...
5 years, 5 months ago (2015-07-15 17:31:28 UTC) #3
agrieve
https://codereview.chromium.org/1233313003/diff/1/tools/android/md5sum/BUILD.gn File tools/android/md5sum/BUILD.gn (right): https://codereview.chromium.org/1233313003/diff/1/tools/android/md5sum/BUILD.gn#newcode47 tools/android/md5sum/BUILD.gn:47: # Symlink rather than copy so that it still ...
5 years, 5 months ago (2015-07-15 17:57:53 UTC) #4
brettw
lgtm
5 years, 5 months ago (2015-07-15 17:58:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1233313003/20001
5 years, 5 months ago (2015-07-15 18:13:38 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-15 20:13:24 UTC) #8
commit-bot: I haz the power
5 years, 5 months ago (2015-07-15 20:14:32 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/6cc97ff4e7c37054de5931e2ce07fb469766d204
Cr-Commit-Position: refs/heads/master@{#338898}

Powered by Google App Engine
This is Rietveld 408576698