Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 1416683004: Port enable_resource_whitelist_generation GYP->GN (Closed)

Created:
5 years, 1 month ago by agrieve
Modified:
5 years, 1 month ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Port enable_resource_whitelist_generation GYP->GN BUG=551576 Committed: https://crrev.com/7a2c6b09316b1fa695fac516c428e8bff068173f Cr-Commit-Position: refs/heads/master@{#358060}

Patch Set 1 #

Patch Set 2 : move cflags to public_config #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -3 lines) Patch
M build/secondary/tools/grit/grit_rule.gni View 1 3 chunks +22 lines, -3 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (3 generated)
agrieve
On 2015/11/04 20:47:33, agrieve wrote: > mailto:agrieve@chromium.org changed reviewers: > + mailto:aurimas@chromium.org ptal, based on ...
5 years, 1 month ago (2015-11-04 20:48:08 UTC) #3
agrieve
On 2015/11/04 20:48:08, agrieve wrote: > On 2015/11/04 20:47:33, agrieve wrote: > > mailto:agrieve@chromium.org changed ...
5 years, 1 month ago (2015-11-04 20:48:40 UTC) #4
aurimas (slooooooooow)
On 2015/11/04 at 20:48:40, agrieve wrote: > On 2015/11/04 20:48:08, agrieve wrote: > > On ...
5 years, 1 month ago (2015-11-04 21:46:03 UTC) #5
aurimas (slooooooooow)
lgtm
5 years, 1 month ago (2015-11-04 21:46:30 UTC) #6
agrieve
On 2015/11/04 21:46:03, aurimas wrote: > On 2015/11/04 at 20:48:40, agrieve wrote: > > On ...
5 years, 1 month ago (2015-11-05 14:52:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1416683004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1416683004/20001
5 years, 1 month ago (2015-11-05 14:54:01 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-05 15:40:44 UTC) #10
commit-bot: I haz the power
5 years, 1 month ago (2015-11-05 15:41:27 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7a2c6b09316b1fa695fac516c428e8bff068173f
Cr-Commit-Position: refs/heads/master@{#358060}

Powered by Google App Engine
This is Rietveld 408576698