Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Issue 1278793003: GN: Fix clean build of cloud_policy_proto_generated_compile_proto failing (Closed)

Created:
5 years, 4 months ago by agrieve
Modified:
5 years, 4 months ago
Reviewers:
brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN: Fix clean build of cloud_policy_proto_generated_compile_proto failing Failed due to forward_variables_from("deps") clobbering existing deps, and ./protoc not being built before invoking it. Commit that introduced this bug: https://crrev.com/a09029884e02a3c027a485877886cf75969f6b3d BUG= Committed: https://crrev.com/4fb6b6f46c01262f37c7a170f3de2366f4d8cedf Cr-Commit-Position: refs/heads/master@{#342205}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M third_party/protobuf/proto_library.gni View 1 chunk +3 lines, -2 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 7 (2 generated)
agrieve
Seems like this is also indicative of a bug in GN, since the docs say: ...
5 years, 4 months ago (2015-08-06 18:37:32 UTC) #2
brettw
lgtm
5 years, 4 months ago (2015-08-06 19:04:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1278793003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1278793003/1
5 years, 4 months ago (2015-08-06 19:59:15 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-06 21:42:02 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-06 21:42:36 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4fb6b6f46c01262f37c7a170f3de2366f4d8cedf
Cr-Commit-Position: refs/heads/master@{#342205}

Powered by Google App Engine
This is Rietveld 408576698