GN: Add missing deps for incremental apks.

GN: Add missing deps for incremental apks.

Was broken by recent commit: http://crrev.com/3bd8449

BUG=533442
Committed: https://crrev.com/8f96adc65258bf999417cefb8c5aead6a8ed0876
Cr-Commit-Position: refs/heads/master@{#350825}

[agrieve, 2015-09-24 19:42:41]

agrieve@chromium.org changed reviewers:
+ pkotwicz@chromium.org

[pkotwicz, 2015-09-24 21:31:53]

https://codereview.chromium.org/1360233006/diff/1/build/config/android/rules.gni
File build/config/android/rules.gni (right):

https://codereview.chromium.org/1360233006/diff/1/build/config/android/rules....
build/config/android/rules.gni:1544: ":$java_target",
I wonder whether we should add $java_target to deps in addition to
incremental_deps

What steps did you do to get a build failure? (I want to reproduce it to better
understand the issue). I understand that "final_dex_target_name" depends on
"java_target". However, I do not yet understand why the "java_target" dependency
is important here

https://codereview.chromium.org/1360233006/diff/1/build/config/android/rules....
build/config/android/rules.gni:1559: deps += invoker.deps
This is a no-op?

[agrieve, 2015-09-24 22:22:57]

https://codereview.chromium.org/1360233006/diff/1/build/config/android/rules.gni
File build/config/android/rules.gni (right):

https://codereview.chromium.org/1360233006/diff/1/build/config/android/rules....
build/config/android/rules.gni:1544: ":$java_target",
On 2015/09/24 21:31:53, pkotwicz wrote:
> I wonder whether we should add $java_target to deps in addition to
> incremental_deps
> 
> What steps did you do to get a build failure? (I want to reproduce it to
better
> understand the issue). I understand that "final_dex_target_name" depends on
> "java_target". However, I do not yet understand why the "java_target"
dependency
> is important here

We shouldn't add it to deps, because it's not a direct dependency of the actual
apk. The actual APK needs only the classes.dex file, which includes $java_target
in it.

The template actually also doesn't need $java_target. I should have added it to
_incremental_final_deps, which I've now done.

To test it out, build any APK and add _incremental. 
e.g. ninja chrome_public_apk_incremental
Then run:
out-gn/Debug/bin/install_incremental_chrome_public_apk

https://codereview.chromium.org/1360233006/diff/1/build/config/android/rules....
build/config/android/rules.gni:1559: deps += invoker.deps
On 2015/09/24 21:31:53, pkotwicz wrote:
> This is a no-op?

hmm, yes it is! Removed.

[agrieve, 2015-09-25 14:15:08]

added a comment.

[pkotwicz, 2015-09-25 14:19:30]

https://codereview.chromium.org/1360233006/diff/40001/build/config/android/ru...
File build/config/android/rules.gni (right):

https://codereview.chromium.org/1360233006/diff/40001/build/config/android/ru...
build/config/android/rules.gni:1648: # depend on them here.
Thanks for the comment!

[pkotwicz, 2015-09-25 14:19:35]

lgtm

[agrieve, 2015-09-25 14:24:26]

The CQ bit was checked by agrieve@chromium.org

[commit-bot: I haz the power, 2015-09-25 14:24:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1360233006/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1360233006/40001

[commit-bot: I haz the power, 2015-09-25 14:52:26]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-09-25 14:53:21]

Patchset 3 (id:??) landed as
https://crrev.com/8f96adc65258bf999417cefb8c5aead6a8ed0876
Cr-Commit-Position: refs/heads/master@{#350825}