Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 1325133003: GN: Put .jar files in lib.java rather than gen/ (Closed)

Created:
5 years, 3 months ago by agrieve
Modified:
5 years, 3 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN: Put .jar files in lib.java rather than gen/ BUG=527501 Committed: https://crrev.com/d1621831ec5f9fc8a57a0d8c256f7cd0ee561eab Cr-Commit-Position: refs/heads/master@{#347092}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M build/config/android/internal_rules.gni View 2 chunks +10 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 7 (2 generated)
agrieve
5 years, 3 months ago (2015-09-02 20:24:54 UTC) #2
Dirk Pranke
lgtm
5 years, 3 months ago (2015-09-02 20:31:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1325133003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1325133003/1
5 years, 3 months ago (2015-09-03 00:51:40 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-03 01:53:48 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-03 01:54:28 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d1621831ec5f9fc8a57a0d8c256f7cd0ee561eab
Cr-Commit-Position: refs/heads/master@{#347092}

Powered by Google App Engine
This is Rietveld 408576698