Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1428173002: GN: Remove "outputs" parameter for java_cpp_enum() (Closed)

Created:
5 years, 1 month ago by agrieve
Modified:
5 years, 1 month ago
Reviewers:
brettw
CC:
chromium-reviews, zea+watch_chromium.org, vmpstr+watch_chromium.org, posciak+watch_chromium.org, nektar+watch_chromium.org, noyau+watch_chromium.org, dmazzoni+watch_chromium.org, mlamouri+watch-media_chromium.org, tim+watch_chromium.org, cbentzel+watch_chromium.org, aboxhall+watch_chromium.org, jam, pvalenzuela+watch_chromium.org, dglazkov+blink, je_julie, darin-cc_chromium.org, yfriedman+watch_chromium.org, blink-reviews, blink-reviews-api_chromium.org, android-webview-reviews_chromium.org, yuzo+watch_chromium.org, feature-media-reviews_chromium.org, plundblad+watch_chromium.org, tfarina, maxbogue+watch_chromium.org, avayvod+watch_chromium.org, mcasas+watch_chromium.org, jbudorick+watch_chromium.org, plaree+watch_chromium.org, mikecase+watch_chromium.org, dtseng+watch_chromium.org, klundberg+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN: Remove "outputs" parameter for java_cpp_enum() This is strictly a simplification refactor. BUG= Committed: https://crrev.com/bee8261c3df26813c56395cb78854a583dc82069 Cr-Commit-Position: refs/heads/master@{#357831}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -193 lines) Patch
M android_webview/native/BUILD.gn View 1 chunk +0 lines, -3 lines 0 comments Download
M base/BUILD.gn View 1 chunk +0 lines, -6 lines 0 comments Download
M build/android/gyp/java_cpp_enum.py View 5 chunks +43 lines, -25 lines 0 comments Download
M build/android/gyp/java_cpp_enum_tests.py View 1 chunk +2 lines, -1 line 0 comments Download
M build/android/gyp/util/build_utils.py View 3 chunks +13 lines, -8 lines 0 comments Download
M build/config/android/rules.gni View 1 chunk +16 lines, -53 lines 0 comments Download
M chrome/BUILD.gn View 3 chunks +0 lines, -9 lines 0 comments Download
M chrome/android/BUILD.gn View 1 chunk +0 lines, -10 lines 0 comments Download
M components/bookmarks/common/android/BUILD.gn View 1 chunk +0 lines, -3 lines 0 comments Download
M components/enhanced_bookmarks/BUILD.gn View 1 chunk +0 lines, -3 lines 0 comments Download
M components/offline_pages/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M components/omnibox/browser/BUILD.gn View 1 chunk +0 lines, -3 lines 0 comments Download
M content/browser/accessibility/BUILD.gn View 2 chunks +1 line, -4 lines 0 comments Download
M content/public/android/BUILD.gn View 1 chunk +0 lines, -17 lines 0 comments Download
M media/base/android/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M net/android/BUILD.gn View 2 chunks +0 lines, -12 lines 0 comments Download
M sync/android/BUILD.gn View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/public/BUILD.gn View 1 chunk +0 lines, -6 lines 0 comments Download
M ui/accessibility/BUILD.gn View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/android/BUILD.gn View 1 chunk +0 lines, -10 lines 0 comments Download
M ui/touch_selection/BUILD.gn View 1 chunk +0 lines, -6 lines 0 comments Download

Depends on Patchset:

Issue 1217063002 Patch 1

Messages

Total messages: 7 (2 generated)
agrieve
5 years, 1 month ago (2015-11-03 21:05:03 UTC) #2
brettw
lgtm
5 years, 1 month ago (2015-11-04 11:44:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1428173002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1428173002/1
5 years, 1 month ago (2015-11-04 15:32:22 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-04 16:51:11 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-04 16:52:14 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/bee8261c3df26813c56395cb78854a583dc82069
Cr-Commit-Position: refs/heads/master@{#357831}

Powered by Google App Engine
This is Rietveld 408576698