Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 1389363003: apk_helper: Extract all values from manifest rather than dump badging (Closed)

Created:
5 years, 2 months ago by agrieve
Modified:
5 years, 2 months ago
Reviewers:
jbudorick
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

apk_helper: Extract all values from manifest rather than dump badging - dump xmltree and dump badging take the same amount of time to run - Might as well speed things up by using only the (cached) manifest BUG=540857 Committed: https://crrev.com/e7b15a576120435acb2ad7de8efb8d94ebd6347d Cr-Commit-Position: refs/heads/master@{#353296}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -38 lines) Patch
M build/android/devil/android/apk_helper.py View 4 chunks +18 lines, -38 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 7 (2 generated)
agrieve
On 2015/10/09 00:55:54, agrieve wrote: > mailto:agrieve@chromium.org changed reviewers: > + mailto:jbudorick@chromium.org ♦
5 years, 2 months ago (2015-10-09 00:56:08 UTC) #2
jbudorick
lgtm eagerly awaiting ♥ and ♣
5 years, 2 months ago (2015-10-09 01:10:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1389363003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1389363003/1
5 years, 2 months ago (2015-10-09 14:38:58 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-09 15:44:18 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-09 15:44:55 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e7b15a576120435acb2ad7de8efb8d94ebd6347d
Cr-Commit-Position: refs/heads/master@{#353296}

Powered by Google App Engine
This is Rietveld 408576698