Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(873)

Issue 1402473002: Fix md5_check.py crashing when adding a new zip file (Closed)

Created:
5 years, 2 months ago by agrieve
Modified:
5 years, 2 months ago
Reviewers:
Xi Han
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix md5_check.py crashing when adding a new zip file BUG= Committed: https://crrev.com/7f620841dcd4224de82dd39a769f38e1c8621bc9 Cr-Commit-Position: refs/heads/master@{#353313}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M build/android/gyp/util/md5_check.py View 1 chunk +4 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 6 (2 generated)
Xi Han
Thanks for the quick fix. LGTM!
5 years, 2 months ago (2015-10-09 15:45:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1402473002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1402473002/1
5 years, 2 months ago (2015-10-09 15:53:50 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-09 17:07:18 UTC) #5
commit-bot: I haz the power
5 years, 2 months ago (2015-10-09 17:09:00 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7f620841dcd4224de82dd39a769f38e1c8621bc9
Cr-Commit-Position: refs/heads/master@{#353313}

Powered by Google App Engine
This is Rietveld 408576698