Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issue 1258923012: GN (Android): Make is_clang work for (at least for arm32) (Closed)

Created:
5 years, 4 months ago by agrieve
Modified:
5 years, 4 months ago
Reviewers:
cjhopman, brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN (Android): Make is_clang work for (at least for arm32) There seem to be more compiler flags to tweak for other target architectures, but with this I could at least build & run chrome_apk with is_clang=true BUG=402625 Committed: https://crrev.com/91d9b7ee4e51168ef413265e33b8fe25253a1758 Cr-Commit-Position: refs/heads/master@{#342227}

Patch Set 1 #

Patch Set 2 : fix nacl build errors #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -24 lines) Patch
M build/config/BUILDCONFIG.gn View 1 1 chunk +5 lines, -1 line 0 comments Download
M build/config/compiler/BUILD.gn View 1 5 chunks +40 lines, -15 lines 0 comments Download
M build/toolchain/android/BUILD.gn View 7 chunks +38 lines, -8 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (5 generated)
agrieve
5 years, 4 months ago (2015-07-31 20:31:23 UTC) #2
brettw
lgtm
5 years, 4 months ago (2015-07-31 23:27:44 UTC) #3
cjhopman
lgtm
5 years, 4 months ago (2015-08-04 23:10:39 UTC) #4
commit-bot: I haz the power
This CL has an open dependency (Issue 1278793003 Patch 1). Please resolve the dependency and ...
5 years, 4 months ago (2015-08-06 19:59:14 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1258923012/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1258923012/20001
5 years, 4 months ago (2015-08-06 21:45:31 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-06 23:18:55 UTC) #11
commit-bot: I haz the power
5 years, 4 months ago (2015-08-06 23:19:40 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/91d9b7ee4e51168ef413265e33b8fe25253a1758
Cr-Commit-Position: refs/heads/master@{#342227}

Powered by Google App Engine
This is Rietveld 408576698