Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(739)

Issue 1261873003: Add haha to third-party (Closed)

Created:
5 years, 4 months ago by agrieve
Modified:
4 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add haha to third-party It is a dependency of Leak Canary, which I'd like to add next. BUG=505909 Committed: https://crrev.com/63a79760afb4a25023368311e6906e7462b87c28 Cr-Commit-Position: refs/heads/master@{#374846}

Patch Set 1 #

Patch Set 2 : add BUILD.gn #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -11 lines) Patch
A + third_party/haha/BUILD.gn View 1 1 chunk +4 lines, -5 lines 0 comments Download
A + third_party/haha/LICENSE View 1 2 chunks +26 lines, -0 lines 0 comments Download
A + third_party/haha/OWNERS View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A third_party/haha/README.chromium View 1 chunk +23 lines, -0 lines 0 comments Download
A + third_party/haha/haha.gyp View 1 chunk +4 lines, -7 lines 0 comments Download
A third_party/haha/haha-2.0.2.jar View Binary file 0 comments Download

Depends on Patchset:

Messages

Total messages: 14 (5 generated)
agrieve
5 years, 4 months ago (2015-07-30 17:49:28 UTC) #2
agrieve
On 2015/07/30 17:49:28, agrieve wrote: bump
5 years, 4 months ago (2015-08-06 01:20:25 UTC) #3
klobag.chromium
On 2015/08/06 01:20:25, agrieve wrote: > On 2015/07/30 17:49:28, agrieve wrote: > > bump Will ...
5 years, 4 months ago (2015-08-07 19:43:35 UTC) #4
agrieve
On 2015/08/07 19:43:35, klobag.chromium wrote: > On 2015/08/06 01:20:25, agrieve wrote: > > On 2015/07/30 ...
5 years, 4 months ago (2015-08-07 19:51:01 UTC) #5
klobag.chromium
On 2015/08/07 19:51:01, agrieve wrote: > On 2015/08/07 19:43:35, klobag.chromium wrote: > > On 2015/08/06 ...
5 years, 4 months ago (2015-08-07 20:28:45 UTC) #6
Daniel Berlin
LGTM for OSTPR
5 years, 4 months ago (2015-08-10 21:17:11 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1261873003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1261873003/20001
4 years, 10 months ago (2016-02-11 01:44:47 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-11 03:12:27 UTC) #12
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:34:21 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/63a79760afb4a25023368311e6906e7462b87c28
Cr-Commit-Position: refs/heads/master@{#374846}

Powered by Google App Engine
This is Rietveld 408576698