Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 1382413002: DeviceUtils._PushChangedFilesZipped: use default temp file directory (Closed)

Created:
5 years, 2 months ago by agrieve
Modified:
5 years, 2 months ago
Reviewers:
jbudorick
CC:
chromium-reviews, asanka, benjhayden+dwatch_chromium.org, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DeviceUtils._PushChangedFilesZipped: use default temp file directory Shell user does not always have permissions to push to /sdcard (e.g. not on my Android One). BUG= Committed: https://crrev.com/a2e7284f627019cc7bf2d9d7d4381a3d1b4c7254 Cr-Commit-Position: refs/heads/master@{#352341}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M build/android/devil/android/device_utils.py View 1 chunk +1 line, -2 lines 0 comments Download
M build/android/devil/android/device_utils_test.py View 1 chunk +1 line, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 7 (2 generated)
agrieve
On 2015/10/05 15:24:55, agrieve wrote: > mailto:agrieve@chromium.org changed reviewers: > + mailto:jbudorick@chromium.org not sure why ...
5 years, 2 months ago (2015-10-05 15:25:54 UTC) #2
jbudorick
lgtm
5 years, 2 months ago (2015-10-05 15:34:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1382413002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1382413002/1
5 years, 2 months ago (2015-10-05 15:57:40 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-05 17:29:16 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-05 17:31:29 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a2e7284f627019cc7bf2d9d7d4381a3d1b4c7254
Cr-Commit-Position: refs/heads/master@{#352341}

Powered by Google App Engine
This is Rietveld 408576698