Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Issue 1350363002: Make use of md5_check within write_build_config.py (Closed)

Created:
5 years, 3 months ago by agrieve
Modified:
5 years, 2 months ago
Reviewers:
pkotwicz
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@md5-check-3
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make use of md5_check within write_build_config.py Just for the write_ordered_libraries() part, which is where 95% of the time is spent. BUG=533442 Committed: https://crrev.com/c03d57bc86a906986933a906c60e27ec61c04052 Cr-Commit-Position: refs/heads/master@{#350832}

Patch Set 1 #

Patch Set 2 : fix a couple whoopsies #

Patch Set 3 : gonna get this right... #

Patch Set 4 : rebase #

Patch Set 5 : fix empty libs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -14 lines) Patch
M build/android/gyp/write_build_config.py View 1 2 3 4 2 chunks +28 lines, -14 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 15 (7 generated)
agrieve
pTaL
5 years, 3 months ago (2015-09-24 19:50:41 UTC) #4
pkotwicz
5 years, 3 months ago (2015-09-24 20:32:01 UTC) #5
pkotwicz
lgtm
5 years, 3 months ago (2015-09-24 20:32:45 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1350363002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1350363002/60001
5 years, 3 months ago (2015-09-25 02:16:20 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/136903)
5 years, 3 months ago (2015-09-25 02:40:40 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1350363002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1350363002/80001
5 years, 2 months ago (2015-09-25 13:53:35 UTC) #13
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 2 months ago (2015-09-25 15:26:42 UTC) #14
commit-bot: I haz the power
5 years, 2 months ago (2015-09-25 15:28:21 UTC) #15
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/c03d57bc86a906986933a906c60e27ec61c04052
Cr-Commit-Position: refs/heads/master@{#350832}

Powered by Google App Engine
This is Rietveld 408576698