Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(854)

Issue 1335983002: DeviceUtils: Fix SU command for pre-M devices

Created:
5 years, 3 months ago by agrieve
Modified:
5 years, 3 months ago
Reviewers:
jbudorick
CC:
chromium-reviews, jbudorick+watch_chromium.org, klundberg+watch_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DeviceUtils: Fix SU command for pre-M devices su -c CMD <-- CMD needs quoting su 0 CMD <-- CMD does not need quoting Ran into this when md5sum.py was trying to update the binary on a kitkat device and needed to rm -rf it first. BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M build/android/devil/android/device_utils.py View 1 chunk +1 line, -1 line 0 comments Download
M build/android/devil/android/device_utils_test.py View 1 chunk +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (5 generated)
agrieve
5 years, 3 months ago (2015-09-11 15:38:16 UTC) #2
jbudorick
lgtm Odd that we didn't hit this previously (or prior to https://codereview.chromium.org/1317453004)
5 years, 3 months ago (2015-09-11 15:40:38 UTC) #3
agrieve
On 2015/09/11 15:40:38, jbudorick wrote: > lgtm > > Odd that we didn't hit this ...
5 years, 3 months ago (2015-09-11 15:56:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1335983002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1335983002/1
5 years, 3 months ago (2015-09-11 15:56:25 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/67717)
5 years, 3 months ago (2015-09-11 16:43:46 UTC) #8
jbudorick
On 2015/09/11 at 15:56:03, agrieve wrote: > On 2015/09/11 15:40:38, jbudorick wrote: > > lgtm ...
5 years, 3 months ago (2015-09-11 16:46:07 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1335983002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1335983002/1
5 years, 3 months ago (2015-09-11 17:38:48 UTC) #11
jbudorick
5 years, 3 months ago (2015-09-11 17:41:17 UTC) #13
On 2015/09/11 at 17:40:19, jbudorick wrote:
> The CQ bit was unchecked by jbudorick@chromium.org

I took this out of the CQ because:
 - I don't think it'll pass, given the way it failed in the same way twice
 - Even if it does pass, I don't think it's something we want to land given the
failures that occurred.

Powered by Google App Engine
This is Rietveld 408576698