Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 1473273002: GN(Android): Add libosmesa.so to ContentShell.apk (Closed)

Created:
5 years ago by agrieve
Modified:
5 years ago
Reviewers:
Dirk Pranke, pkotwicz, piman
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, Peter Beverloo, jam, jbudorick+watch_chromium.org, darin-cc_chromium.org, mikecase+watch_chromium.org, mkwst+moarreviews-shell_chromium.org, klundberg+watch_chromium.org, jochen+watch_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN(Android): Add libosmesa.so to ContentShell.apk BUG=559289 Committed: https://crrev.com/da37b9ba5421dc03b28d507c2de7a422790a190a Cr-Commit-Position: refs/heads/master@{#362866}

Patch Set 1 #

Total comments: 10

Patch Set 2 : add comment #

Total comments: 2

Patch Set 3 : rebase #

Total comments: 4

Patch Set 4 : comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -67 lines) Patch
M build/config/android/rules.gni View 1 2 3 5 chunks +20 lines, -6 lines 0 comments Download
M build/toolchain/android/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download
M build/toolchain/gcc_toolchain.gni View 1 2 3 1 chunk +5 lines, -1 line 0 comments Download
M content/shell/android/BUILD.gn View 1 chunk +2 lines, -5 lines 0 comments Download
M third_party/mesa/BUILD.gn View 1 chunk +46 lines, -55 lines 0 comments Download

Messages

Total messages: 31 (11 generated)
agrieve
pkotwicz - Please look at build/ piman - Please look at content/ and third_party/mesa/
5 years ago (2015-11-24 16:29:45 UTC) #2
piman
lgtm
5 years ago (2015-11-24 21:29:40 UTC) #3
pkotwicz
Andrew, did you manage to get ContentShell.apk not to crash when --use-gl=osmesa is passed on ...
5 years ago (2015-11-25 01:18:34 UTC) #4
agrieve
https://codereview.chromium.org/1473273002/diff/1/build/config/android/rules.gni File build/config/android/rules.gni (right): https://codereview.chromium.org/1473273002/diff/1/build/config/android/rules.gni#newcode1199 build/config/android/rules.gni:1199: # * not side-loaded for _incremental targets. On 2015/11/25 ...
5 years ago (2015-11-25 21:26:57 UTC) #5
pkotwicz
Just to confirm, did you manage to get ContentShell.apk not to crash when --use-gl=osmesa is ...
5 years ago (2015-11-25 22:41:25 UTC) #6
agrieve
On 2015/11/25 22:41:25, pkotwicz wrote: > Just to confirm, did you manage to get ContentShell.apk ...
5 years ago (2015-11-26 02:56:13 UTC) #7
agrieve
https://codereview.chromium.org/1473273002/diff/1/build/config/android/rules.gni File build/config/android/rules.gni (right): https://codereview.chromium.org/1473273002/diff/1/build/config/android/rules.gni#newcode1623 build/config/android/rules.gni:1623: rebased_gdbserver, On 2015/11/25 21:26:57, agrieve wrote: > On 2015/11/25 ...
5 years ago (2015-11-26 03:11:08 UTC) #8
pkotwicz
L - G - T - M once you remove native-libs-dir arg from apkbuilder.py https://codereview.chromium.org/1473273002/diff/20001/build/config/android/internal_rules.gni ...
5 years ago (2015-11-26 21:17:45 UTC) #9
agrieve
On 2015/11/26 21:17:45, pkotwicz wrote: > L - G - T - M once you ...
5 years ago (2015-12-01 23:43:20 UTC) #10
pkotwicz
build/config/android/rules.gni LGTM Thank you for being patient with me! I am not comfortable reviewing build/toolchain ...
5 years ago (2015-12-02 01:33:05 UTC) #11
pkotwicz
jbudorick@ can you please take a look at the changes in build/toolchain ?
5 years ago (2015-12-02 01:33:24 UTC) #12
agrieve
On 2015/12/02 01:33:24, pkotwicz wrote: > jbudorick@ can you please take a look at the ...
5 years ago (2015-12-02 14:40:28 UTC) #15
agrieve
https://codereview.chromium.org/1473273002/diff/40001/build/config/android/rules.gni File build/config/android/rules.gni (right): https://codereview.chromium.org/1473273002/diff/40001/build/config/android/rules.gni#newcode1196 build/config/android/rules.gni:1196: # * dependencies of this .so are not automatically ...
5 years ago (2015-12-02 14:49:52 UTC) #16
jbudorick
On 2015/12/02 14:40:28, agrieve wrote: > On 2015/12/02 01:33:24, pkotwicz wrote: > > jbudorick@ can ...
5 years ago (2015-12-02 14:54:02 UTC) #17
Dirk Pranke
lgtm
5 years ago (2015-12-02 18:43:48 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1473273002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1473273002/60001
5 years ago (2015-12-02 18:48:46 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/148958)
5 years ago (2015-12-02 20:06:01 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1473273002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1473273002/60001
5 years ago (2015-12-03 01:09:16 UTC) #27
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years ago (2015-12-03 02:17:16 UTC) #29
commit-bot: I haz the power
5 years ago (2015-12-03 02:18:00 UTC) #31
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/da37b9ba5421dc03b28d507c2de7a422790a190a
Cr-Commit-Position: refs/heads/master@{#362866}

Powered by Google App Engine
This is Rietveld 408576698