Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1416313002: GN(Android): Fix up webkit_unit_tests to match GYP (Closed)

Created:
5 years, 2 months ago by agrieve
Modified:
5 years, 2 months ago
Reviewers:
haraken, pkotwicz, brettw
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN(Android): Fix up webkit_unit_tests to match GYP BUG=510485 Committed: https://crrev.com/fe6e80680a98401465ae0f75053a492061765d85 Cr-Commit-Position: refs/heads/master@{#355720}

Patch Set 1 #

Patch Set 2 : use existing content shell assets target #

Patch Set 3 : delete a couple unused imports now that not doing own assets #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -20 lines) Patch
M third_party/WebKit/Source/bindings/bindings.gni View 3 chunks +25 lines, -20 lines 0 comments Download
M third_party/WebKit/Source/web/BUILD.gn View 1 2 1 chunk +9 lines, -0 lines 0 comments Download

Depends on Patchset:

Issue 1217063002 Patch 1

Messages

Total messages: 9 (2 generated)
agrieve
5 years, 2 months ago (2015-10-22 16:08:23 UTC) #2
pkotwicz
lgtm
5 years, 2 months ago (2015-10-22 17:04:30 UTC) #3
haraken
LGTM
5 years, 2 months ago (2015-10-22 23:23:38 UTC) #4
brettw
lgtm
5 years, 2 months ago (2015-10-23 00:01:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1416313002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1416313002/40001
5 years, 2 months ago (2015-10-23 02:25:52 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 2 months ago (2015-10-23 03:12:46 UTC) #8
commit-bot: I haz the power
5 years, 2 months ago (2015-10-23 03:13:29 UTC) #9
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/fe6e80680a98401465ae0f75053a492061765d85
Cr-Commit-Position: refs/heads/master@{#355720}

Powered by Google App Engine
This is Rietveld 408576698