Android test_runner.py: Eliminate unused "adb devices" call for gtests

Android test_runner.py: Eliminate unused "adb devices" call for gtests

Applies to junit and python tests as well.

BUG=540857
Committed: https://crrev.com/18930bdc3e8f077a3508121b0ce4e34386878db2
Cr-Commit-Position: refs/heads/master@{#353322}

[agrieve, 2015-10-09 00:26:03]

agrieve@chromium.org changed reviewers:
+ jbudorick@chromium.org

[agrieve, 2015-10-09 00:26:25]

On 2015/10/09 00:26:03, agrieve wrote:
> mailto:agrieve@chromium.org changed reviewers:
> + mailto:jbudorick@chromium.org

♠

[jbudorick, 2015-10-09 00:28:48]

https://codereview.chromium.org/1397013002/diff/1/build/android/test_runner.py
File build/android/test_runner.py (right):

https://codereview.chromium.org/1397013002/diff/1/build/android/test_runner.p...
build/android/test_runner.py:916: if args.enable_platform_mode:
alternatively, we could just switch this to

  if args.enable_platform_mode or command == 'gtest':

(this is where I'm going with https://codereview.chromium.org/1387933005/, but
that CL will take a little while)

[agrieve, 2015-10-09 00:58:54]

https://codereview.chromium.org/1397013002/diff/1/build/android/test_runner.py
File build/android/test_runner.py (right):

https://codereview.chromium.org/1397013002/diff/1/build/android/test_runner.p...
build/android/test_runner.py:916: if args.enable_platform_mode:
On 2015/10/09 00:28:48, jbudorick wrote:
> alternatively, we could just switch this to
> 
>   if args.enable_platform_mode or command == 'gtest':
> 
> (this is where I'm going with https://codereview.chromium.org/1387933005/, but
> that CL will take a little while)

Interesting! Sounds good except with the change as-is it also skips the device
check for 'python' and 'junit'. Update description to mention this.

[jbudorick, 2015-10-09 01:00:20]

lgtm

https://codereview.chromium.org/1397013002/diff/20001/build/android/test_runn...
File build/android/test_runner.py (left):

https://codereview.chromium.org/1397013002/diff/20001/build/android/test_runn...
build/android/test_runner.py:924: if command in constants.LOCAL_MACHINE_TESTS:
This was already skipping the device check for python & junit.

[agrieve, 2015-10-09 01:04:39]

https://codereview.chromium.org/1397013002/diff/20001/build/android/test_runn...
File build/android/test_runner.py (left):

https://codereview.chromium.org/1397013002/diff/20001/build/android/test_runn...
build/android/test_runner.py:924: if command in constants.LOCAL_MACHINE_TESTS:
On 2015/10/09 01:00:20, jbudorick wrote:
> This was already skipping the device check for python & junit.

oooooooh. I got it.
Removed the LOCAL_MACHINE_TESTS check in get_devices() since it's not necessary.

[jbudorick, 2015-10-09 01:06:28]

https://codereview.chromium.org/1397013002/diff/40001/build/android/test_runn...
File build/android/test_runner.py (right):

https://codereview.chromium.org/1397013002/diff/40001/build/android/test_runn...
build/android/test_runner.py:928: def get_devices():
oh, hrm. That wasn't what I meant, but this is fine.

[agrieve, 2015-10-09 16:00:42]

The CQ bit was checked by agrieve@chromium.org

[agrieve, 2015-10-09 16:00:42]

The patchset sent to the CQ was uploaded after l-g-t-m from
jbudorick@chromium.org
Link to the patchset: https://codereview.chromium.org/1397013002/#ps40001
(title: "remove unnecessary check")

[commit-bot: I haz the power, 2015-10-09 16:04:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1397013002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1397013002/40001

[commit-bot: I haz the power, 2015-10-09 17:41:50]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-10-09 17:43:11]

Patchset 3 (id:??) landed as
https://crrev.com/18930bdc3e8f077a3508121b0ce4e34386878db2
Cr-Commit-Position: refs/heads/master@{#353322}