Android GTest Runner: Don't clear app data for incremental installs

Android GTest Runner: Don't clear app data for incremental installs

base_unittests before:
2m22s
after:
2m7s

BUG=540857
Committed: https://crrev.com/194be30aea9ca121c4731572a0757ef6aaafe752
Cr-Commit-Position: refs/heads/master@{#355226}

[agrieve, 2015-10-20 18:54:24]

Description was changed from

==========
Android GTest Runner: Don't clear app data for incremental installs

base_unittests before:
2m22s
after:
2m7s

BUG=540857
==========

to

==========
Android GTest Runner: Don't clear app data for incremental installs

base_unittests before:
2m22s
after:
2m7s

BUG=540857
==========

[agrieve, 2015-10-20 18:54:25]

agrieve@chromium.org changed reviewers:
+ jbudorick@chromium.org

[agrieve, 2015-10-20 18:56:43]

On 2015/10/20 18:54:25, agrieve wrote:
> mailto:agrieve@chromium.org changed reviewers:
> + mailto:jbudorick@chromium.org

My thoughts about this:
- Seems unit tests are sharded somewhat arbitrarily, so clearing data between
shards shouldn't be relied on since one test could end up in a different shard
once more tests are added
- If it helps bot stability though, might as well clear data.
- Not sure it's worth adding a new flag to toggle this separately though.
- Incremental installs don't make sense for non-apk targets anyways, so ignoring
that this doesn't call Clear for ExeDelegates

[jbudorick, 2015-10-20 20:06:40]

lgtm

On 2015/10/20 18:56:43, agrieve wrote:
> On 2015/10/20 18:54:25, agrieve wrote:
> > mailto:agrieve@chromium.org changed reviewers:
> > + mailto:jbudorick@chromium.org
> 
> My thoughts about this:
> - Seems unit tests are sharded somewhat arbitrarily, so clearing data between
> shards shouldn't be relied on since one test could end up in a different shard
> once more tests are added

Yeah, there's a different between what "should" happen here...

> - If it helps bot stability though, might as well clear data.

... and what does.

> - Not sure it's worth adding a new flag to toggle this separately though.

I don't think it is.

> - Incremental installs don't make sense for non-apk targets anyways, so
ignoring
> that this doesn't call Clear for ExeDelegates

This was the case I was worried about.

[agrieve, 2015-10-21 01:41:14]

The CQ bit was checked by agrieve@chromium.org

[commit-bot: I haz the power, 2015-10-21 01:41:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1414923003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1414923003/1

[commit-bot: I haz the power, 2015-10-21 02:48:39]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-10-21 02:50:02]

Patchset 1 (id:??) landed as
https://crrev.com/194be30aea9ca121c4731572a0757ef6aaafe752
Cr-Commit-Position: refs/heads/master@{#355226}