GN: Add missing dependency for wm_unittests on ui_test_pak

GN: Add missing dependency for wm_unittests on ui_test_pak

BUG=

Committed: https://crrev.com/419d43ab9e998c0866b8a915d9b64a4575f55247
Cr-Commit-Position: refs/heads/master@{#341837}

[agrieve, 2015-07-31 18:19:57]

agrieve@chromium.org changed reviewers:
+ brettw@chromium.org

[agrieve, 2015-07-31 18:19:58]

This seems to be breaking my shlib dir change (ugh)

[brettw, 2015-07-31 20:46:23]

lgtm

https://codereview.chromium.org/1256793011/diff/1/ui/wm/BUILD.gn
File ui/wm/BUILD.gn (right):

https://codereview.chromium.org/1256793011/diff/1/ui/wm/BUILD.gn#newcode153
ui/wm/BUILD.gn:153: "$root_out_dir/ui_test.pak",
It seems like this line should be unnecessary now.

[agrieve, 2015-08-05 00:43:40]

https://codereview.chromium.org/1256793011/diff/1/ui/wm/BUILD.gn
File ui/wm/BUILD.gn (right):

https://codereview.chromium.org/1256793011/diff/1/ui/wm/BUILD.gn#newcode153
ui/wm/BUILD.gn:153: "$root_out_dir/ui_test.pak",
On 2015/07/31 20:46:23, brettw wrote:
> It seems like this line should be unnecessary now.

Done - is it always an error to list a file within $root_out_dir within the data
attribute?

[agrieve, 2015-08-05 00:46:31]

The CQ bit was checked by agrieve@chromium.org

[agrieve, 2015-08-05 00:46:31]

The patchset sent to the CQ was uploaded after l-g-t-m from brettw@chromium.org
Link to the patchset: https://codereview.chromium.org/1256793011/#ps20001
(title: "remove data =")

[commit-bot: I haz the power, 2015-08-05 00:46:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1256793011/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1256793011/20001

[brettw, 2015-08-05 00:58:55]

https://codereview.chromium.org/1256793011/diff/1/ui/wm/BUILD.gn
File ui/wm/BUILD.gn (right):

https://codereview.chromium.org/1256793011/diff/1/ui/wm/BUILD.gn#newcode153
ui/wm/BUILD.gn:153: "$root_out_dir/ui_test.pak",
On 2015/08/05 00:43:40, agrieve wrote:
> On 2015/07/31 20:46:23, brettw wrote:
> > It seems like this line should be unnecessary now.
> 
> Done - is it always an error to list a file within $root_out_dir within the
data
> attribute?

No, but generally a data file should be listed once and a target should get it
by depending on the target that made it or is associated with it. In this case,
you get it by depending on ui_test_pak, so it should be listed there (however
best it is expressed for whatever type of file it is) and it shouldn't be listed
again in places like this.

[commit-bot: I haz the power, 2015-08-05 01:20:01]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-08-05 01:22:40]

Patchset 2 (id:??) landed as
https://crrev.com/419d43ab9e998c0866b8a915d9b64a4575f55247
Cr-Commit-Position: refs/heads/master@{#341837}