Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issue 1361013003: Fix build_utils.ExtractAll not respecting pattern parameter. (Closed)

Created:
5 years, 3 months ago by agrieve
Modified:
5 years, 3 months ago
Reviewers:
hartmanng
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix build_utils.ExtractAll not respecting pattern parameter. It is currently used only by javac.py, and the extra files being extracted has not been a problem. BUG= Committed: https://crrev.com/32df3c4353b7b6ba2c763aec80594876e39f3f3b Cr-Commit-Position: refs/heads/master@{#350458}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M build/android/gyp/util/build_utils.py View 1 chunk +1 line, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 17 (7 generated)
hartmanng
lgtm
5 years, 3 months ago (2015-09-23 14:42:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1361013003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1361013003/1
5 years, 3 months ago (2015-09-23 14:49:10 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/116833) win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, ...
5 years, 3 months ago (2015-09-23 14:58:03 UTC) #6
jbudorick
On 2015/09/23 at 14:58:03, commit-bot wrote: > Try jobs failed on following builders: > mac_chromium_rel_ng ...
5 years, 3 months ago (2015-09-23 14:59:25 UTC) #7
agrieve
On 2015/09/23 14:59:25, jbudorick wrote: > On 2015/09/23 at 14:58:03, commit-bot wrote: > > Try ...
5 years, 3 months ago (2015-09-23 15:12:01 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1361013003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1361013003/1
5 years, 3 months ago (2015-09-23 18:25:25 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/106754)
5 years, 3 months ago (2015-09-23 19:48:32 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1361013003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1361013003/1
5 years, 3 months ago (2015-09-24 02:26:52 UTC) #14
commit-bot: I haz the power
Failed to commit the patch.
5 years, 3 months ago (2015-09-24 03:03:52 UTC) #16
commit-bot: I haz the power
5 years, 3 months ago (2015-09-24 03:06:44 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/32df3c4353b7b6ba2c763aec80594876e39f3f3b
Cr-Commit-Position: refs/heads/master@{#350458}

Powered by Google App Engine
This is Rietveld 408576698