Reland of GN(android): Add work-around for "project database corrupted" error

Reland of GN(android): Add work-around for "project database corrupted" error (patchset #1 id:1 of https://codereview.chromium.org/1411183007/ )

Reason for revert:
reland with a fix

Original issue's description:
> Revert of GN(android): Add work-around for "project database corrupted" error (patchset #2 id:20001 of https://codereview.chromium.org/1407043010/ )
>
> Reason for revert:
> This also popped up on WebRTC: https://code.google.com/p/webrtc/issues/detail?id=5169
>
> Original issue's description:
> > GN(android): Add work-around for "project database corrupted" error
> >
> > Happens randomly when compiling java with enable_incremental_javac=true.
> >
> > BUG=551449
> >
> > Committed: https://crrev.com/b09587112b3c257f02b9bca2ad19d1a48919b74d
> > Cr-Commit-Position: refs/heads/master@{#357904}
>
> TBR=yfriedman@chromium.org,agrieve@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=551449
>
> Committed: https://crrev.com/b846ee6f792433a243f0129d93061c955487eb62
> Cr-Commit-Position: refs/heads/master@{#358094}

BUG=551449
Committed: https://crrev.com/10a89642498aca7282ae1bbbd069c18490cffc07
Cr-Commit-Position: refs/heads/master@{#358332}

[agrieve, 2015-11-05 19:44:09]

Created Reland of GN(android): Add work-around for "project database corrupted"
error

[agrieve, 2015-11-05 19:44:29]

Description was changed from

==========
Reland of GN(android): Add work-around for "project database corrupted" error
(patchset #1 id:1 of https://codereview.chromium.org/1411183007/ )

Reason for revert:
reland with a fix

Original issue's description:
> Revert of GN(android): Add work-around for "project database corrupted" error
(patchset #2 id:20001 of https://codereview.chromium.org/1407043010/ )
> 
> Reason for revert:
> This also popped up on WebRTC:
https://code.google.com/p/webrtc/issues/detail?id=5169
> 
> Original issue's description:
> > GN(android): Add work-around for "project database corrupted" error
> >
> > Happens randomly when compiling java with enable_incremental_javac=true.
> >
> > BUG=551449
> >
> > Committed: https://crrev.com/b09587112b3c257f02b9bca2ad19d1a48919b74d
> > Cr-Commit-Position: refs/heads/master@{#357904}
> 
> TBR=yfriedman@chromium.org,agrieve@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=551449
> 
> Committed: https://crrev.com/b846ee6f792433a243f0129d93061c955487eb62
> Cr-Commit-Position: refs/heads/master@{#358094}

TBR=yfriedman@chromium.org,jbudorick@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=551449
==========

to

==========
Reland of GN(android): Add work-around for "project database corrupted" error
(patchset #1 id:1 of https://codereview.chromium.org/1411183007/ )

Reason for revert:
reland with a fix

Original issue's description:
> Revert of GN(android): Add work-around for "project database corrupted" error
(patchset #2 id:20001 of https://codereview.chromium.org/1407043010/ )
> 
> Reason for revert:
> This also popped up on WebRTC:
https://code.google.com/p/webrtc/issues/detail?id=5169
> 
> Original issue's description:
> > GN(android): Add work-around for "project database corrupted" error
> >
> > Happens randomly when compiling java with enable_incremental_javac=true.
> >
> > BUG=551449
> >
> > Committed: https://crrev.com/b09587112b3c257f02b9bca2ad19d1a48919b74d
> > Cr-Commit-Position: refs/heads/master@{#357904}
> 
> TBR=yfriedman@chromium.org,agrieve@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=551449
> 
> Committed: https://crrev.com/b846ee6f792433a243f0129d93061c955487eb62
> Cr-Commit-Position: refs/heads/master@{#358094}

BUG=551449
==========

[agrieve, 2015-11-05 20:15:21]

On 2015/11/05 19:44:09, agrieve wrote:
> Created Reland of GN(android): Add work-around for "project database
corrupted"
> error

ptal - verified that compiles still fail when they should.

[jbudorick, 2015-11-05 20:47:45]

https://codereview.chromium.org/1408213011/diff/40001/build/android/gyp/javac.py
File build/android/gyp/javac.py (right):

https://codereview.chromium.org/1408213011/diff/40001/build/android/gyp/javac...
build/android/gyp/javac.py:255: attempt_build()
Why was the second build not causing failures before?

[agrieve, 2015-11-05 21:02:10]

https://codereview.chromium.org/1408213011/diff/40001/build/android/gyp/javac.py
File build/android/gyp/javac.py (right):

https://codereview.chromium.org/1408213011/diff/40001/build/android/gyp/javac...
build/android/gyp/javac.py:255: attempt_build()
On 2015/11/05 20:47:45, jbudorick wrote:
> Why was the second build not causing failures before?

It was not re-raising the exception :(

[jbudorick, 2015-11-05 21:03:07]

On 2015/11/05 21:02:10, agrieve wrote:
>
https://codereview.chromium.org/1408213011/diff/40001/build/android/gyp/javac.py
> File build/android/gyp/javac.py (right):
> 
>
https://codereview.chromium.org/1408213011/diff/40001/build/android/gyp/javac...
> build/android/gyp/javac.py:255: attempt_build()
> On 2015/11/05 20:47:45, jbudorick wrote:
> > Why was the second build not causing failures before?
> 
> It was not re-raising the exception :(

The second call to attempt_build should raise the same exception though, right?
The build should have still failed.

[agrieve, 2015-11-05 21:40:14]

On 2015/11/05 21:03:07, jbudorick wrote:
> On 2015/11/05 21:02:10, agrieve wrote:
> >
>
https://codereview.chromium.org/1408213011/diff/40001/build/android/gyp/javac.py
> > File build/android/gyp/javac.py (right):
> > 
> >
>
https://codereview.chromium.org/1408213011/diff/40001/build/android/gyp/javac...
> > build/android/gyp/javac.py:255: attempt_build()
> > On 2015/11/05 20:47:45, jbudorick wrote:
> > > Why was the second build not causing failures before?
> > 
> > It was not re-raising the exception :(
> 
> The second call to attempt_build should raise the same exception though,
right?
> The build should have still failed.

In the case where it fails *not* because of corrupt pdb, it was not re-raising
nor retrying.

[jbudorick, 2015-11-05 21:41:12]

On 2015/11/05 21:40:14, agrieve wrote:
> On 2015/11/05 21:03:07, jbudorick wrote:
> > On 2015/11/05 21:02:10, agrieve wrote:
> > >
> >
>
https://codereview.chromium.org/1408213011/diff/40001/build/android/gyp/javac.py
> > > File build/android/gyp/javac.py (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/1408213011/diff/40001/build/android/gyp/javac...
> > > build/android/gyp/javac.py:255: attempt_build()
> > > On 2015/11/05 20:47:45, jbudorick wrote:
> > > > Why was the second build not causing failures before?
> > > 
> > > It was not re-raising the exception :(
> > 
> > The second call to attempt_build should raise the same exception though,
> right?
> > The build should have still failed.
> 
> In the case where it fails *not* because of corrupt pdb, it was not re-raising
> nor retrying.

oh, gotcha. indentation change.

[jbudorick, 2015-11-05 21:43:34]

lgtm

[agrieve, 2015-11-06 14:59:13]

The CQ bit was checked by agrieve@chromium.org

[commit-bot: I haz the power, 2015-11-06 14:59:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1408213011/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1408213011/40001

[commit-bot: I haz the power, 2015-11-06 15:19:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-06 15:19:30]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[agrieve, 2015-11-06 15:37:05]

The CQ bit was checked by agrieve@chromium.org

[commit-bot: I haz the power, 2015-11-06 15:37:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1408213011/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1408213011/40001

[commit-bot: I haz the power, 2015-11-06 16:12:30]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2015-11-06 16:13:15]

Patchset 2 (id:??) landed as
https://crrev.com/10a89642498aca7282ae1bbbd069c18490cffc07
Cr-Commit-Position: refs/heads/master@{#358332}