Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 1469943002: GN(android): Fix up support for is_asan=true (Closed)

Created:
5 years ago by agrieve
Modified:
5 years ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, eugenis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN(android): Fix compile when is_asan=true BUG=559284 Committed: https://crrev.com/cea07ed21c3ad2db7b37a3f26ce34d7dd12efe94 Cr-Commit-Position: refs/heads/master@{#361361}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : add include #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -10 lines) Patch
M build/config/android/BUILD.gn View 1 chunk +0 lines, -8 lines 0 comments Download
M build/config/android/internal_rules.gni View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M build/config/sanitizers/BUILD.gn View 1 1 chunk +15 lines, -2 lines 0 comments Download
M build/config/sanitizers/sanitizers.gni View 1 chunk +3 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 15 (7 generated)
agrieve
On 2015/11/23 16:55:56, agrieve wrote: > mailto:agrieve@chromium.org changed reviewers: > + mailto:dpranke@chromium.org ❖
5 years ago (2015-11-23 16:56:09 UTC) #3
Dirk Pranke
lgtm
5 years ago (2015-11-23 22:53:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1469943002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1469943002/20001
5 years ago (2015-11-24 14:52:34 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_dbg/builds/144878) android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED, ...
5 years ago (2015-11-24 14:58:45 UTC) #8
agrieve
On 2015/11/24 14:58:45, commit-bot: I haz the power wrote: > Try jobs failed on following ...
5 years ago (2015-11-24 15:48:20 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1469943002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1469943002/40001
5 years ago (2015-11-24 15:49:26 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years ago (2015-11-24 16:38:07 UTC) #14
commit-bot: I haz the power
5 years ago (2015-11-24 16:39:03 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/cea07ed21c3ad2db7b37a3f26ce34d7dd12efe94
Cr-Commit-Position: refs/heads/master@{#361361}

Powered by Google App Engine
This is Rietveld 408576698