Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1465923002: GN: Merge apk_deps and deps in test() template (Closed)

Created:
5 years, 1 month ago by agrieve
Modified:
5 years ago
Reviewers:
tfarina, brettw
CC:
chromium-reviews, cbentzel+watch_chromium.org, toyoshim+midi_chromium.org, vmpstr+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, blink-reviews, piman+watch_chromium.org, pkotwicz
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN: Merge apk_deps and deps in test() template apk_deps has been causing some unneccesary confusion. BUG=558193 R=tfarina@chromium.org,brettw@chromium.org Committed: https://crrev.com/97176368ff8be424d349132778d9c27624a1232d Cr-Commit-Position: refs/heads/master@{#362432}

Patch Set 1 #

Patch Set 2 : rebased on formatting change #

Total comments: 16

Patch Set 3 : review comments 1 #

Patch Set 4 : rebase #

Patch Set 5 : fix previous rebase #

Patch Set 6 : for realz this time #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -60 lines) Patch
M base/BUILD.gn View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/BUILD.gn View 1 2 3 4 5 1 chunk +4 lines, -4 lines 0 comments Download
M components/BUILD.gn View 1 2 3 4 2 chunks +8 lines, -11 lines 0 comments Download
M components/html_viewer/BUILD.gn View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M content/test/BUILD.gn View 1 2 3 4 chunks +7 lines, -11 lines 0 comments Download
M device/BUILD.gn View 1 2 3 1 chunk +4 lines, -2 lines 0 comments Download
M gpu/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M media/BUILD.gn View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M media/midi/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M net/BUILD.gn View 1 2 3 4 2 chunks +7 lines, -9 lines 0 comments Download
M remoting/BUILD.gn View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M testing/test.gni View 1 2 3 3 chunks +4 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/platform/BUILD.gn View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/BUILD.gn View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M ui/android/BUILD.gn View 1 2 2 chunks +1 line, -1 line 0 comments Download
M ui/base/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 27 (14 generated)
agrieve
5 years, 1 month ago (2015-11-20 18:19:22 UTC) #2
agrieve
On 2015/11/20 18:19:22, agrieve wrote:
5 years, 1 month ago (2015-11-20 18:19:48 UTC) #4
tfarina
lgtm with the below changes. There is oportunity to clean this up :) thanks for ...
5 years, 1 month ago (2015-11-20 18:56:06 UTC) #6
agrieve
https://codereview.chromium.org/1465923002/diff/20001/chrome/test/BUILD.gn File chrome/test/BUILD.gn (right): https://codereview.chromium.org/1465923002/diff/20001/chrome/test/BUILD.gn#newcode1619 chrome/test/BUILD.gn:1619: deps += [ On 2015/11/20 18:56:06, tfarina wrote: > ...
5 years, 1 month ago (2015-11-20 20:06:14 UTC) #8
agrieve
♈ping brettw ♈
5 years, 1 month ago (2015-11-23 15:37:56 UTC) #9
brettw
lgtm
5 years ago (2015-11-25 20:57:47 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1465923002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1465923002/60001
5 years ago (2015-11-27 18:39:38 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_dbg/builds/146375)
5 years ago (2015-11-27 18:45:47 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1465923002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1465923002/80001
5 years ago (2015-12-01 15:03:09 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/164446)
5 years ago (2015-12-01 15:08:54 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1465923002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1465923002/100001
5 years ago (2015-12-01 15:41:55 UTC) #23
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years ago (2015-12-01 16:36:26 UTC) #25
commit-bot: I haz the power
5 years ago (2015-12-01 16:38:01 UTC) #27
Message was sent while issue was closed. 
Patchset 6 (id:??) landed as
https://crrev.com/97176368ff8be424d349132778d9c27624a1232d
Cr-Commit-Position: refs/heads/master@{#362432}

Powered by Google App Engine
This is Rietveld 408576698