Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1435293002: GN: Add quotes when setting BUILD_ID from android_chrome_build_id (Closed)

Created:
5 years, 1 month ago by agrieve
Modified:
5 years, 1 month ago
Reviewers:
brettw
CC:
chromium-reviews, darin-cc_chromium.org, jam, sadrul, kalyank
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN: Add quotes when setting BUILD_ID from android_chrome_build_id BUG=552040 Committed: https://crrev.com/1af0ff405f9a198534487fb56521a908a226022d Cr-Commit-Position: refs/heads/master@{#360656}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/ui/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/crash/content/app/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Issue 1217063002 Patch 1

Messages

Total messages: 8 (2 generated)
agrieve
Don't know much about this other than it fails to compile without quotes :P
5 years, 1 month ago (2015-11-12 15:23:51 UTC) #2
agrieve
On 2015/11/12 15:23:51, agrieve wrote: > Don't know much about this other than it fails ...
5 years, 1 month ago (2015-11-18 16:09:49 UTC) #3
brettw
lgtm
5 years, 1 month ago (2015-11-19 19:26:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1435293002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1435293002/1
5 years, 1 month ago (2015-11-19 19:33:55 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-19 21:00:07 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-11-19 21:01:13 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/1af0ff405f9a198534487fb56521a908a226022d
Cr-Commit-Position: refs/heads/master@{#360656}

Powered by Google App Engine
This is Rietveld 408576698