Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 1332373002: Fix md5sum.py crashing when trying to delete non-existent md5sum directory (Closed)

Created:
5 years, 3 months ago by agrieve
Modified:
5 years, 3 months ago
Reviewers:
perezju, jbudorick
CC:
chromium-reviews, jbudorick+watch_chromium.org, klundberg+watch_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix md5sum.py crashing when trying to delete non-existent md5sum directory "rm -rf foo/" fails, but "rm -rf foo" succeeds BUG= Committed: https://crrev.com/a9d40e8aedcad7433eed48f3437f39f0ccfc2a86 Cr-Commit-Position: refs/heads/master@{#348415}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M build/android/devil/android/md5sum.py View 1 chunk +2 lines, -2 lines 0 comments Download
M build/android/devil/android/md5sum_test.py View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 9 (3 generated)
agrieve
5 years, 3 months ago (2015-09-11 13:58:21 UTC) #2
jbudorick
lgtm
5 years, 3 months ago (2015-09-11 14:02:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1332373002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1332373002/1
5 years, 3 months ago (2015-09-11 15:45:04 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-11 16:54:14 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a9d40e8aedcad7433eed48f3437f39f0ccfc2a86 Cr-Commit-Position: refs/heads/master@{#348415}
5 years, 3 months ago (2015-09-11 16:54:45 UTC) #8
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:23:16 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a9d40e8aedcad7433eed48f3437f39f0ccfc2a86
Cr-Commit-Position: refs/heads/master@{#348415}

Powered by Google App Engine
This is Rietveld 408576698