Issue 1257833003: Make generate_v14_compatible_resources.py not break for non-ascii characters

Issue 1257833003: Make generate_v14_compatible_resources.py not break for non-ascii characters (Closed)

Created:
5 years, 4 months ago by agrieve

Modified:
5 years, 4 months ago

Reviewers:
cjhopman

CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Make generate_v14_compatible_resources.py not break for non-ascii characters Found this when trying to add leakcanary's resources. BUG= Committed: https://crrev.com/0061de986b85de221ad526f6e0aa30648a61d0d1 Cr-Commit-Position: refs/heads/master@{#340901}

Patch Set 1 #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	build/android/gyp/generate_v14_compatible_resources.py	View		2 chunks	+2 lines, -1 line	0 comments	Download

Depends on Patchset:

Issue 1217063002 Patch 1

Dependent Patchsets:

Issue 1261113003 Patch 1

Issue 1261113003 Patch 20001

Messages

Total messages: 8 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1257833003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1257833003/1

5 years, 4 months ago (2015-07-29 15:28:21 UTC) #6

commit-bot: I haz the power

5 years, 4 months ago (2015-07-29 16:49:47 UTC) #8

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/0061de986b85de221ad526f6e0aa30648a61d0d1
Cr-Commit-Position: refs/heads/master@{#340901}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages