GN(Android): Add missing dep for components_unittests

GN(Android): Add missing dep for components_unittests

Requires: //components/policy:policy_component_browser

BUG=507294
Committed: https://crrev.com/a69cf2d9c0368c084d259375e11fe3f114bbb317
Cr-Commit-Position: refs/heads/master@{#342382}

[agrieve, 2015-07-30 18:54:29]

agrieve@chromium.org changed reviewers:
+ blundell@chromium.org

[blundell, 2015-07-30 19:08:45]

lgtm

[agrieve, 2015-07-31 01:20:58]

The CQ bit was checked by agrieve@chromium.org

[commit-bot: I haz the power, 2015-07-31 01:21:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-31 01:21:51]

This CL has an open dependency (Issue 1268513005 Patch 1). Please resolve the
dependency and try again.

[dgn, 2015-07-31 08:41:04]

dgn@chromium.org changed reviewers:
+ dgn@chromium.org

[dgn, 2015-07-31 08:41:05]

https://codereview.chromium.org/1268443004/diff/1/components/BUILD.gn
File components/BUILD.gn (right):

https://codereview.chromium.org/1268443004/diff/1/components/BUILD.gn#newcode322
components/BUILD.gn:322: "//components/policy:policy_component_browser",
This is not a :unit_tests target and should be lower, with the other non
:unit_tests targets.

That being said, the proper solution might just be to make a GN unit_tests
target for the policy component. Filed http://crbug.com/515817. I'll look into
it later. Feel free to grab it if you want.

[blundell, 2015-07-31 08:43:39]

On 2015/07/31 08:41:05, dgn wrote:
> https://codereview.chromium.org/1268443004/diff/1/components/BUILD.gn
> File components/BUILD.gn (right):
> 
>
https://codereview.chromium.org/1268443004/diff/1/components/BUILD.gn#newcode322
> components/BUILD.gn:322: "//components/policy:policy_component_browser",
> This is not a :unit_tests target and should be lower, with the other non
> :unit_tests targets.
> 
> That being said, the proper solution might just be to make a GN unit_tests
> target for the policy component. Filed http://crbug.com/515817. I'll look into
> it later. Feel free to grab it if you want.

Agreed on both counts; I didn't look closely enough when I reviewed.

[agrieve, 2015-07-31 14:23:28]

https://codereview.chromium.org/1268443004/diff/1/components/BUILD.gn
File components/BUILD.gn (right):

https://codereview.chromium.org/1268443004/diff/1/components/BUILD.gn#newcode322
components/BUILD.gn:322: "//components/policy:policy_component_browser",
On 2015/07/31 08:41:05, dgn wrote:
> This is not a :unit_tests target and should be lower, with the other non
> :unit_tests targets.
> 
> That being said, the proper solution might just be to make a GN unit_tests
> target for the policy component. Filed http://crbug.com/515817. I'll look into
> it later. Feel free to grab it if you want.

Just moved it down for now. Thanks!

[agrieve, 2015-07-31 14:24:56]

The CQ bit was checked by agrieve@chromium.org

[agrieve, 2015-07-31 14:24:56]

The patchset sent to the CQ was uploaded after l-g-t-m from
blundell@chromium.org
Link to the patchset: https://codereview.chromium.org/1268443004/#ps20001
(title: "address review comment")

[commit-bot: I haz the power, 2015-07-31 14:25:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1268443004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1268443004/20001

[commit-bot: I haz the power, 2015-07-31 15:33:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-31 15:33:05]

Try jobs failed on following builders:
  win8_chromium_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...)

[agrieve, 2015-07-31 18:47:03]

The CQ bit was checked by agrieve@chromium.org

[commit-bot: I haz the power, 2015-07-31 18:47:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1268443004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1268443004/20001

[commit-bot: I haz the power, 2015-07-31 19:50:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-31 19:50:29]

Try jobs failed on following builders:
  win8_chromium_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...)

[agrieve, 2015-07-31 20:35:26]

On 2015/07/31 19:50:29, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   win8_chromium_ng on tryserver.chromium.win (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...)

dgn / blundell - this seems to be failing on win. Should this be a
non-windows-only dependency?

[agrieve, 2015-07-31 20:36:41]

On 2015/07/31 20:35:26, agrieve wrote:
> On 2015/07/31 19:50:29, commit-bot: I haz the power wrote:
> > Try jobs failed on following builders:
> >   win8_chromium_ng on tryserver.chromium.win (JOB_FAILED,
> >
>
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...)
> 
> dgn / blundell - this seems to be failing on win. Should this be a
> non-windows-only dependency?

Actually, this is broken for a different patch of mine as well:
https://codereview.chromium.org/1236503002/

Just running out the door, but if either of you have time & know who to file a
bug against, I'd be thankful :)

[agrieve, 2015-08-05 00:47:35]

The CQ bit was checked by agrieve@chromium.org

[commit-bot: I haz the power, 2015-08-05 00:48:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1268443004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1268443004/20001

[commit-bot: I haz the power, 2015-08-05 02:04:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-05 02:04:39]

Try jobs failed on following builders:
  win8_chromium_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...)

[agrieve, 2015-08-06 22:49:04]

The CQ bit was checked by agrieve@chromium.org

[agrieve, 2015-08-06 22:49:05]

The patchset sent to the CQ was uploaded after l-g-t-m from
blundell@chromium.org
Link to the patchset: https://codereview.chromium.org/1268443004/#ps40001
(title: "fix win maybe #1")

[commit-bot: I haz the power, 2015-08-06 22:49:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1268443004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1268443004/40001

[commit-bot: I haz the power, 2015-08-07 00:51:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-07 00:51:56]

Try jobs failed on following builders:
  mac_chromium_10.10_rel_ng on tryserver.chromium.mac (JOB_TIMED_OUT, no build
URL)

[agrieve, 2015-08-07 18:01:18]

The CQ bit was checked by agrieve@chromium.org

[commit-bot: I haz the power, 2015-08-07 18:01:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1268443004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1268443004/40001

[commit-bot: I haz the power, 2015-08-07 18:07:49]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-08-07 18:08:30]

Patchset 3 (id:??) landed as
https://crrev.com/a69cf2d9c0368c084d259375e11fe3f114bbb317
Cr-Commit-Position: refs/heads/master@{#342382}