GN: Add an assert for proper output directory nesting on Android

GN: Add an assert for proper output directory nesting on Android

BUG=412935
Committed: https://crrev.com/bdb1d5722535eb8e517b2cc76cbf8db41aecc006
Cr-Commit-Position: refs/heads/master@{#356919}

[agrieve, 2015-10-29 14:44:54]

Description was changed from

==========
GN: Add an assert for proper output directory nesting on Android

BUG=412935
==========

to

==========
GN: Add an assert for proper output directory nesting on Android

BUG=412935
==========

[agrieve, 2015-10-29 14:44:54]

agrieve@chromium.org changed reviewers:
+ pkotwicz@chromium.org

[agrieve, 2015-10-29 14:45:20]

On 2015/10/29 14:44:54, agrieve wrote:
> mailto:agrieve@chromium.org changed reviewers:
> + mailto:pkotwicz@chromium.org

not exactly a fix, but will stop people getting random error messages when they
don't follow the sites page instructions.

[pkotwicz, 2015-10-29 16:11:34]

I got a successful compile when I passed in an out directory which was 4 levels
deep from the src/ directory (I used a/b/c/d in particular)

[agrieve, 2015-10-29 18:21:27]

On 2015/10/29 16:11:34, pkotwicz wrote:
> I got a successful compile when I passed in an out directory which was 4
levels
> deep from the src/ directory (I used a/b/c/d in particular)

There's also code in the test runner script (isolate.py) that assumes this
structure. I don't seen any benefit to supporting other schemes, so don't think
it's worth bothering to fix it so long as we add this assert.

[pkotwicz, 2015-10-29 18:47:59]

lgtm

[agrieve, 2015-10-29 18:59:29]

The CQ bit was checked by agrieve@chromium.org

[commit-bot: I haz the power, 2015-10-29 19:00:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1406173004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1406173004/1

[commit-bot: I haz the power, 2015-10-29 19:52:32]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-10-29 19:53:16]

Patchset 1 (id:??) landed as
https://crrev.com/bdb1d5722535eb8e517b2cc76cbf8db41aecc006
Cr-Commit-Position: refs/heads/master@{#356919}

[Dirk Pranke, 2015-10-29 20:58:01]

this is a temporary thing, right? The correct thing to do is fix the build files
so that we can build anywhere we need to.

[agrieve, 2015-10-30 00:13:17]

On 2015/10/29 20:58:01, Dirk Pranke wrote:
> this is a temporary thing, right? The correct thing to do is fix the build
files
> so that we can build anywhere we need to.

I'm certainly not opposed to someone fixing this, but in my mind it's a P4.

[brettw, 2015-11-01 02:12:20]

On 2015/10/30 00:13:17, agrieve wrote:
> On 2015/10/29 20:58:01, Dirk Pranke wrote:
> > this is a temporary thing, right? The correct thing to do is fix the build
> files
> > so that we can build anywhere we need to.
> 
> I'm certainly not opposed to someone fixing this, but in my mind it's a P4.

Can we add a thing in the assertion string that this not working is a bug that
somebody should fix? I don't want people to think that this must be the case
when they hit the error.

[agrieve, 2015-11-03 16:34:50]

On 2015/11/01 02:12:20, brettw wrote:
> On 2015/10/30 00:13:17, agrieve wrote:
> > On 2015/10/29 20:58:01, Dirk Pranke wrote:
> > > this is a temporary thing, right? The correct thing to do is fix the build
> > files
> > > so that we can build anywhere we need to.
> > 
> > I'm certainly not opposed to someone fixing this, but in my mind it's a P4.
> 
> Can we add a thing in the assertion string that this not working is a bug that
> somebody should fix? I don't want people to think that this must be the case
> when they hit the error.

I added the crbug in the assert message. Should be enough to point out that it's
a bug I think.