Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 1401893003: Fix Android unit tests failing when using a GN output directory of foo/ (Closed)

Created:
5 years, 2 months ago by agrieve
Modified:
5 years, 2 months ago
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org, Primiano Tucci (use gerrit)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix Android unit tests failing when using a GN output directory of foo/ As opposed to out/foo. BUG=542171

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M build/android/pylib/utils/isolator.py View 1 chunk +1 line, -2 lines 1 comment Download

Depends on Patchset:

Messages

Total messages: 10 (4 generated)
agrieve
On 2015/10/14 15:06:59, agrieve wrote: > mailto:agrieve@chromium.org changed reviewers: > + mailto:primiano@chromium.org Turns out the ...
5 years, 2 months ago (2015-10-14 15:07:09 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1401893003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1401893003/1
5 years, 2 months ago (2015-10-14 15:07:34 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/81904)
5 years, 2 months ago (2015-10-14 17:30:35 UTC) #6
Primiano Tucci (use gerrit)
Hmm not really familiar with this code. +jbudorick might be a better choice here.
5 years, 2 months ago (2015-10-14 17:47:01 UTC) #8
jbudorick
https://codereview.chromium.org/1401893003/diff/1/build/android/pylib/utils/isolator.py File build/android/pylib/utils/isolator.py (left): https://codereview.chromium.org/1401893003/diff/1/build/android/pylib/utils/isolator.py#oldcode161 build/android/pylib/utils/isolator.py:161: os.path.relpath(os.path.join(constants.GetOutDirectory(), os.pardir), Yeah, this will definitely break our GYP ...
5 years, 2 months ago (2015-10-14 17:56:30 UTC) #9
agrieve
5 years, 2 months ago (2015-10-14 17:57:49 UTC) #10
On 2015/10/14 17:56:30, jbudorick wrote:
>
https://codereview.chromium.org/1401893003/diff/1/build/android/pylib/utils/i...
> File build/android/pylib/utils/isolator.py (left):
> 
>
https://codereview.chromium.org/1401893003/diff/1/build/android/pylib/utils/i...
> build/android/pylib/utils/isolator.py:161:
> os.path.relpath(os.path.join(constants.GetOutDirectory(), os.pardir),
> Yeah, this will definitely break our GYP builds at least, hence the try job
> failure.

indeed. Abondoning.

Powered by Google App Engine
This is Rietveld 408576698