Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 1420003002: Android gtest runner: Use device.Install(reinstall=True) (Closed)

Created:
5 years, 2 months ago by agrieve
Modified:
5 years, 2 months ago
Reviewers:
jbudorick
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Android gtest runner: Use device.Install(reinstall=True) It speeds things up a bit to not Uninstall then Install. BUG=540857 Committed: https://crrev.com/25d79fc6d47c0f341087284f3e7513725b4b04ba Cr-Commit-Position: refs/heads/master@{#355613}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M build/android/pylib/local/device/local_device_gtest_run.py View 1 chunk +2 lines, -1 line 1 comment Download

Depends on Patchset:

Messages

Total messages: 12 (5 generated)
agrieve
On 2015/10/22 13:37:40, agrieve wrote: > mailto:agrieve@chromium.org changed reviewers: > + mailto:jbudorick@chromium.org ☪
5 years, 2 months ago (2015-10-22 13:37:47 UTC) #3
jbudorick
lgtm https://codereview.chromium.org/1420003002/diff/1/build/android/pylib/local/device/local_device_gtest_run.py File build/android/pylib/local/device/local_device_gtest_run.py (right): https://codereview.chromium.org/1420003002/diff/1/build/android/pylib/local/device/local_device_gtest_run.py#newcode110 build/android/pylib/local/device/local_device_gtest_run.py:110: device.Install(self._apk_helper, reinstall=True, Hrm, I was worried about how ...
5 years, 2 months ago (2015-10-22 15:14:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1420003002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1420003002/1
5 years, 2 months ago (2015-10-22 16:09:30 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/84794)
5 years, 2 months ago (2015-10-22 17:03:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1420003002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1420003002/1
5 years, 2 months ago (2015-10-22 18:36:24 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-22 19:41:31 UTC) #11
commit-bot: I haz the power
5 years, 2 months ago (2015-10-22 19:43:03 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/25d79fc6d47c0f341087284f3e7513725b4b04ba
Cr-Commit-Position: refs/heads/master@{#355613}

Powered by Google App Engine
This is Rietveld 408576698