Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1325783005: GN: Respect testonly in compiled_action and compiled_action_foreach (Closed)

Created:
5 years, 3 months ago by agrieve
Modified:
5 years, 3 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN: Respect testonly in compiled_action and compiled_action_foreach Also refactors them to use forward_variables_from() BUG= Committed: https://crrev.com/cdf0f11f9a64990b8f60f5df541525eaad434c6d Cr-Commit-Position: refs/heads/master@{#347162}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -34 lines) Patch
M build/compiled_action.gni View 4 chunks +23 lines, -34 lines 0 comments Download

Depends on Patchset:

Issue 1217063002 Patch 1

Dependent Patchsets:

Issue 1323053003 Patch 1
Issue 1323053003 Patch 20001

Messages

Total messages: 7 (2 generated)
agrieve
5 years, 3 months ago (2015-09-03 02:44:13 UTC) #2
Dirk Pranke
lgtm
5 years, 3 months ago (2015-09-03 15:32:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1325783005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1325783005/1
5 years, 3 months ago (2015-09-03 15:34:41 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-03 15:58:50 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-03 15:59:46 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/cdf0f11f9a64990b8f60f5df541525eaad434c6d
Cr-Commit-Position: refs/heads/master@{#347162}

Powered by Google App Engine
This is Rietveld 408576698