GN: Enable proguard for apks

GN: Enable proguard for apks

This moves a little bit more about how to run proguard for test apks into
proguard_utils.py and adds the gn rules/etc for running proguard on apks.

BUG=554513
Committed: https://crrev.com/cad0cf822a69c34bc91564348af9a6bb1c3b3e25
Cr-Commit-Position: refs/heads/master@{#359152}

[agrieve, 2015-11-11 18:02:21]

agrieve@chromium.org changed reviewers:
+ newt@chromium.org

[agrieve, 2015-11-11 18:02:22]

This is just https://codereview.chromium.org/1133013003/ with conflicts resolved
:)

[newt (away), 2015-11-11 18:21:33]

lgtm after comments

https://codereview.chromium.org/1433873004/diff/1/build/android/gyp/util/prog...
File build/android/gyp/util/proguard_util.py (right):

https://codereview.chromium.org/1433873004/diff/1/build/android/gyp/util/prog...
build/android/gyp/util/proguard_util.py:82: if not self._cmd:
an early return would be nice here to reduce nesting

https://codereview.chromium.org/1433873004/diff/1/build/android/gyp/write_bui...
File build/android/gyp/write_build_config.py (right):

https://codereview.chromium.org/1433873004/diff/1/build/android/gyp/write_bui...
build/android/gyp/write_build_config.py:386: 
too many newlines

https://codereview.chromium.org/1433873004/diff/1/build/config/android/intern...
File build/config/android/internal_rules.gni (right):

https://codereview.chromium.org/1433873004/diff/1/build/config/android/intern...
build/config/android/internal_rules.gni:283: type = invoker.type
Do you still need "assert(defined(invoker.type))" and
"assert(defined(invoker.build_config))"?

[agrieve, 2015-11-11 18:53:45]

https://codereview.chromium.org/1433873004/diff/1/build/android/gyp/util/prog...
File build/android/gyp/util/proguard_util.py (right):

https://codereview.chromium.org/1433873004/diff/1/build/android/gyp/util/prog...
build/android/gyp/util/proguard_util.py:82: if not self._cmd:
On 2015/11/11 18:21:33, newt wrote:
> an early return would be nice here to reduce nesting

Done.

https://codereview.chromium.org/1433873004/diff/1/build/android/gyp/write_bui...
File build/android/gyp/write_build_config.py (right):

https://codereview.chromium.org/1433873004/diff/1/build/android/gyp/write_bui...
build/android/gyp/write_build_config.py:386: 
On 2015/11/11 18:21:33, newt wrote:
> too many newlines

Done.

https://codereview.chromium.org/1433873004/diff/1/build/config/android/intern...
File build/config/android/internal_rules.gni (right):

https://codereview.chromium.org/1433873004/diff/1/build/config/android/intern...
build/config/android/internal_rules.gni:283: type = invoker.type
On 2015/11/11 18:21:33, newt wrote:
> Do you still need "assert(defined(invoker.type))" and
> "assert(defined(invoker.build_config))"?

Thought they were a bit redundant. GN throws an error upon trying to access
invoker.type if it's not defined.

[newt (away), 2015-11-11 18:55:01]

https://codereview.chromium.org/1433873004/diff/1/build/config/android/intern...
File build/config/android/internal_rules.gni (right):

https://codereview.chromium.org/1433873004/diff/1/build/config/android/intern...
build/config/android/internal_rules.gni:283: type = invoker.type
On 2015/11/11 18:53:45, agrieve wrote:
> On 2015/11/11 18:21:33, newt wrote:
> > Do you still need "assert(defined(invoker.type))" and
> > "assert(defined(invoker.build_config))"?
> 
> Thought they were a bit redundant. GN throws an error upon trying to access
> invoker.type if it's not defined.

Fair enough.

[agrieve, 2015-11-11 19:30:27]

The CQ bit was checked by agrieve@chromium.org

[agrieve, 2015-11-11 19:30:28]

The patchset sent to the CQ was uploaded after l-g-t-m from newt@chromium.org
Link to the patchset: https://codereview.chromium.org/1433873004/#ps20001
(title: "review nites")

[commit-bot: I haz the power, 2015-11-11 19:32:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1433873004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1433873004/20001

[commit-bot: I haz the power, 2015-11-11 20:54:19]

Committed patchset #2 (id:20001)

[agrieve, 2015-11-12 01:32:42]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1436083002/ by agrieve@chromium.org.

The reason for reverting is: Broke gn-release-builder-l
https://uberchromegw.corp.google.com/i/internal.client.clank/builders/gn-rele....

[commit-bot: I haz the power, 2015-11-12 20:00:09]

Patchset 2 (id:??) landed as
https://crrev.com/cad0cf822a69c34bc91564348af9a6bb1c3b3e25
Cr-Commit-Position: refs/heads/master@{#359152}