Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 1432583003: Findbugs: Ignore all genereted Manifest classes. (Closed)

Created:
5 years, 1 month ago by agrieve
Modified:
5 years, 1 month ago
Reviewers:
pkotwicz
CC:
chromium-reviews, klundberg+watch_chromium.org, mikecase+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Findbugs: Ignore all generated Manifest classes. Not just those that begin with org.chromium. BUG=550985 Committed: https://crrev.com/d2182b19a04159920c3472401b4d0efe732651d6 Cr-Commit-Position: refs/heads/master@{#357601}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M build/android/findbugs_filter/findbugs_exclude.xml View 1 chunk +2 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 9 (4 generated)
agrieve
On 2015/11/03 17:54:58, agrieve wrote: > mailto:agrieve@chromium.org changed reviewers: > + mailto:pkotwicz@chromium.org The reason this ...
5 years, 1 month ago (2015-11-03 17:55:36 UTC) #3
pkotwicz
lgtm
5 years, 1 month ago (2015-11-03 18:42:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1432583003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1432583003/1
5 years, 1 month ago (2015-11-03 19:36:05 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-03 20:12:01 UTC) #8
commit-bot: I haz the power
5 years, 1 month ago (2015-11-03 20:13:30 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d2182b19a04159920c3472401b4d0efe732651d6
Cr-Commit-Position: refs/heads/master@{#357601}

Powered by Google App Engine
This is Rietveld 408576698