Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 1319523002: Reland: Use --num-thread=10 when dexing Android code (saves 5 seconds) (Closed)

Created:
5 years, 4 months ago by agrieve
Modified:
5 years, 3 months ago
Reviewers:
jbudorick
CC:
chromium-reviews, jbudorick+watch_chromium.org, klundberg+watch_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland: Use --num-thread=10 when dexing Android code (saves 5 seconds) This reverts commit a9975e3af252dbb1f28b55ed5398731e576b482e. The dex tool has now fixed the non-determinism bug. BUG= Committed: https://crrev.com/20dfd3e71f88d45bf9edbeebf5b89f403e1ba3ff Cr-Commit-Position: refs/heads/master@{#345512}

Patch Set 1 #

Patch Set 2 : add comment & rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M build/android/gyp/dex.py View 1 1 chunk +4 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 9 (3 generated)
agrieve
5 years, 4 months ago (2015-08-25 16:06:56 UTC) #2
jbudorick
lgtm but this is liable to conflict with my multidex CL, which is currently in ...
5 years, 4 months ago (2015-08-25 16:08:10 UTC) #3
agrieve
On 2015/08/25 16:06:56, agrieve wrote: Verified by building chrome_apk's classes.dex, then building it again and ...
5 years, 4 months ago (2015-08-25 16:08:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1319523002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1319523002/20001
5 years, 3 months ago (2015-08-25 23:43:34 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-08-26 00:56:43 UTC) #8
commit-bot: I haz the power
5 years, 3 months ago (2015-08-26 00:57:12 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/20dfd3e71f88d45bf9edbeebf5b89f403e1ba3ff
Cr-Commit-Position: refs/heads/master@{#345512}

Powered by Google App Engine
This is Rietveld 408576698