Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Issue 1232063008: Run javap with a bigger NewSize to fix crash when processing robolectric.jar (Closed)

Created:
5 years, 5 months ago by agrieve
Modified:
5 years, 5 months ago
Reviewers:
cjhopman
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Run javap with a bigger NewSize to fix crash when processing robolectric.jar Crash looks like: GC triggered before VM initialization completed. Try increasing NewSize BUG=507294 Committed: https://crrev.com/b0991387175e0dc39063bdaa0d8fa1ff51ea90a6 Cr-Commit-Position: refs/heads/master@{#338625}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M build/android/gyp/jar_toc.py View 1 chunk +1 line, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (4 generated)
agrieve
5 years, 5 months ago (2015-07-11 02:10:28 UTC) #2
cjhopman
lgtm
5 years, 5 months ago (2015-07-13 21:58:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1232063008/1
5 years, 5 months ago (2015-07-14 00:56:03 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/79904)
5 years, 5 months ago (2015-07-14 01:18:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1232063008/1
5 years, 5 months ago (2015-07-14 02:07:54 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-14 02:36:37 UTC) #10
commit-bot: I haz the power
5 years, 5 months ago (2015-07-14 02:37:40 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b0991387175e0dc39063bdaa0d8fa1ff51ea90a6
Cr-Commit-Position: refs/heads/master@{#338625}

Powered by Google App Engine
This is Rietveld 408576698