Change BuildInfo.hasApkSplits -> BuildInfo.hasLanguageApkSplits

Change BuildInfo.hasApkSplits -> BuildInfo.hasLanguageApkSplits

It's possible to have a configuration where splits exist (e.g. abi,
density), but language splits don't exist. We were previously doing the
wrong thing in this case.

BUG=490285
Committed: https://crrev.com/d2d2337bf7955d184a2085f184231ee691df57cd
Cr-Commit-Position: refs/heads/master@{#338338}

[agrieve, 2015-07-08 20:39:01]

agrieve@chromium.org changed reviewers:
+ jochen@chromium.org, yfriedman@chromium.org

[agrieve, 2015-07-08 20:39:02]

jochen@chromium.org: Please review changes in base/

yfriedman@chromium.org: Please review changes in chrome/

[Yaron, 2015-07-08 21:31:22]

https://codereview.chromium.org/1227793002/diff/1/base/android/java/src/org/c...
File base/android/java/src/org/chromium/base/BuildInfo.java (right):

https://codereview.chromium.org/1227793002/diff/1/base/android/java/src/org/c...
base/android/java/src/org/chromium/base/BuildInfo.java:139: return
splitName.length() == 9 && splitName.startsWith("config.");
we control the split name, don't we? can we make it more explicit that it's a
language split?

[agrieve, 2015-07-09 00:11:30]

https://codereview.chromium.org/1227793002/diff/1/base/android/java/src/org/c...
File base/android/java/src/org/chromium/base/BuildInfo.java (right):

https://codereview.chromium.org/1227793002/diff/1/base/android/java/src/org/c...
base/android/java/src/org/chromium/base/BuildInfo.java:139: return
splitName.length() == 9 && splitName.startsWith("config.");
On 2015/07/08 21:31:22, Yaron wrote:
> we control the split name, don't we? can we make it more explicit that it's a
> language split?

Yeah, I don't love this either, but we don't control the name for resource
splits. Only for abi splits.

[Yaron, 2015-07-09 12:32:24]

lgtm

[jochen (gone - plz use gerrit), 2015-07-10 08:43:07]

i'm not a base/ owner

[Yaron, 2015-07-10 12:22:20]

I'm a base/android OWNER so I think you're actually set

[Yaron, 2015-07-10 12:23:22]

On 2015/07/10 12:22:20, Yaron wrote:
> I'm a base/android OWNER so I think you're actually set

err, actually, I think Andrew just had it reversed. He needs your approval for
chrome/

[jochen (gone - plz use gerrit), 2015-07-10 12:27:47]

lgtm

[agrieve, 2015-07-10 17:14:30]

The CQ bit was checked by agrieve@chromium.org

[commit-bot: I haz the power, 2015-07-10 17:14:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1227793002/1

[commit-bot: I haz the power, 2015-07-10 19:37:04]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-07-10 19:37:55]

Patchset 1 (id:??) landed as
https://crrev.com/d2d2337bf7955d184a2085f184231ee691df57cd
Cr-Commit-Position: refs/heads/master@{#338338}