Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 1420983002: GN(Android): Fix up blink_heap_unittests to match GYP (Closed)

Created:
5 years, 2 months ago by agrieve
Modified:
5 years, 2 months ago
Reviewers:
pkotwicz, brettw
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN(Android): Fix up blink_heap_unittests to match GYP BUG=510485 Committed: https://crrev.com/c5abf6f8a22e44d42d8134c57f687cc181f44dd6 Cr-Commit-Position: refs/heads/master@{#355719}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M third_party/WebKit/Source/platform/BUILD.gn View 2 chunks +9 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 7 (2 generated)
agrieve
5 years, 2 months ago (2015-10-22 20:31:39 UTC) #2
brettw
lgtm
5 years, 2 months ago (2015-10-23 02:11:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1420983002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1420983002/1
5 years, 2 months ago (2015-10-23 02:25:54 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-23 03:11:11 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-23 03:11:57 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c5abf6f8a22e44d42d8134c57f687cc181f44dd6
Cr-Commit-Position: refs/heads/master@{#355719}

Powered by Google App Engine
This is Rietveld 408576698