Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1413753005: GN: Remove mentions of lib.stripped (Closed)

Created:
5 years, 1 month ago by agrieve
Modified:
5 years, 1 month ago
Reviewers:
Yaron, yzshen1
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN: Remove mentions of lib.stripped It was changed to lib.unstripped a while ago. BUG= Committed: https://crrev.com/96faf63bcc0f03cf9f7f9c2e56e7cb471a547b84 Cr-Commit-Position: refs/heads/master@{#359103}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -10 lines) Patch
M build/toolchain/gcc_toolchain.gni View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/mojo_application.gni View 2 chunks +2 lines, -8 lines 0 comments Download

Depends on Patchset:

Issue 1217063002 Patch 1

Messages

Total messages: 11 (3 generated)
agrieve
yfriedman@chromium.org: Please review changes in chrome jamesr@chromium.org: Please review changes in mojo
5 years, 1 month ago (2015-11-05 21:00:28 UTC) #2
Yaron
lgtm
5 years, 1 month ago (2015-11-06 13:50:26 UTC) #3
jamesr
5 years, 1 month ago (2015-11-09 17:48:01 UTC) #5
agrieve
On 2015/11/09 17:48:01, jamesr wrote: ping
5 years, 1 month ago (2015-11-10 20:19:34 UTC) #6
yzshen1
On 2015/11/10 20:19:34, agrieve wrote: > On 2015/11/09 17:48:01, jamesr wrote: > > ping LGTM ...
5 years, 1 month ago (2015-11-11 16:07:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1413753005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1413753005/1
5 years, 1 month ago (2015-11-11 16:14:32 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-11 17:08:48 UTC) #10
commit-bot: I haz the power
5 years, 1 month ago (2015-11-12 19:58:09 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/96faf63bcc0f03cf9f7f9c2e56e7cb471a547b84
Cr-Commit-Position: refs/heads/master@{#359103}

Powered by Google App Engine
This is Rietveld 408576698