Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(568)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1438013006: Delete a few no-longer-relevant TODO(GYP) comments (Closed)

Created:
5 years, 1 month ago by agrieve
Modified:
5 years, 1 month ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, Peter Beverloo, jam, darin-cc_chromium.org, mkwst+moarreviews-shell_chromium.org, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Delete a few no-longer-relevant TODO(GYP) comments BUG= Committed: https://crrev.com/ae47459c25210f9de67ed1bf5062959a982cd7e2 Cr-Commit-Position: refs/heads/master@{#360351}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -11 lines) Patch
M chrome/android/BUILD.gn View 1 chunk +0 lines, -7 lines 0 comments Download
M content/public/android/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/shell/android/BUILD.gn View 1 chunk +0 lines, -3 lines 0 comments Download

Depends on Patchset:

Issue 1217063002 Patch 1

Messages

Total messages: 9 (3 generated)
agrieve
Yaron - please confirm forwarder1 isn't a thing that will ever be needed.
5 years, 1 month ago (2015-11-12 21:22:16 UTC) #2
Yaron
See this CL in my inbox from 2.5 years ago: https://codereview.chromium.org/11189032/ I assume it's done, ...
5 years, 1 month ago (2015-11-12 21:52:49 UTC) #4
brettw
lgtm
5 years, 1 month ago (2015-11-17 22:08:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1438013006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1438013006/1
5 years, 1 month ago (2015-11-18 16:11:02 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-18 17:16:08 UTC) #8
commit-bot: I haz the power
5 years, 1 month ago (2015-11-18 17:17:15 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/ae47459c25210f9de67ed1bf5062959a982cd7e2
Cr-Commit-Position: refs/heads/master@{#360351}

Powered by Google App Engine
This is Rietveld 408576698