Refactor adb_*_command_line helpers bash->python

Refactor adb_*_command_line helpers bash->python

* Now targets all devices by default rather than failing
* Allows --device flag to target a specific device

BUG=

Committed: https://crrev.com/d7c8cc052f46bc38cb7eb5fafda396b8c2e3cd0c
Cr-Commit-Position: refs/heads/master@{#361343}

[agrieve, 2015-11-23 18:48:37]

Description was changed from

==========
Refactor adb_*_command_line helpers bash->python

* Now targets all devices by default rather than failing
* Allows --device flag to target a specific device

BUG=
==========

to

==========
Refactor adb_*_command_line helpers bash->python

* Now targets all devices by default rather than failing
* Allows --device flag to target a specific device

BUG=
==========

[agrieve, 2015-11-23 18:48:37]

agrieve@chromium.org changed reviewers:
+ jbudorick@chromium.org

[agrieve, 2015-11-23 18:48:49]

On 2015/11/23 18:48:37, agrieve wrote:
> mailto:agrieve@chromium.org changed reviewers:
> + mailto:jbudorick@chromium.org

✐

[jbudorick, 2015-11-23 20:02:10]

overall, nice clean up.

https://codereview.chromium.org/1469143002/diff/1/build/android/adb_command_l...
File build/android/adb_command_line.py (right):

https://codereview.chromium.org/1469143002/diff/1/build/android/adb_command_l...
build/android/adb_command_line.py:79: 
nit: return 0 at the end

https://codereview.chromium.org/1469143002/diff/1/build/android/adb_content_s...
File build/android/adb_content_shell_command_line (right):

https://codereview.chromium.org/1469143002/diff/1/build/android/adb_content_s...
build/android/adb_content_shell_command_line:17:
/data/local/tmp/content-shell-command-line "$@"
Does this work with both the no-arg case and the single arg empty string case?

[agrieve, 2015-11-23 20:42:48]

https://codereview.chromium.org/1469143002/diff/1/build/android/adb_command_l...
File build/android/adb_command_line.py (right):

https://codereview.chromium.org/1469143002/diff/1/build/android/adb_command_l...
build/android/adb_command_line.py:79: 
On 2015/11/23 20:02:10, jbudorick wrote:
> nit: return 0 at the end

Done.

https://codereview.chromium.org/1469143002/diff/1/build/android/adb_content_s...
File build/android/adb_content_shell_command_line (right):

https://codereview.chromium.org/1469143002/diff/1/build/android/adb_content_s...
build/android/adb_content_shell_command_line:17:
/data/local/tmp/content-shell-command-line "$@"
On 2015/11/23 20:02:10, jbudorick wrote:
> Does this work with both the no-arg case and the single arg empty string case?

It does. "$@" is magic!

[jbudorick, 2015-11-23 20:44:21]

lgtm, couldn't find an appropriate emoji for "magic" at a glance.

[agrieve, 2015-11-23 21:29:00]

The CQ bit was checked by agrieve@chromium.org

[commit-bot: I haz the power, 2015-11-23 21:30:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1469143002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1469143002/20001

[commit-bot: I haz the power, 2015-11-23 23:08:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-23 23:08:33]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[agrieve, 2015-11-24 03:50:29]

The CQ bit was checked by agrieve@chromium.org

[commit-bot: I haz the power, 2015-11-24 03:53:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1469143002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1469143002/20001

[commit-bot: I haz the power, 2015-11-24 05:22:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-24 05:22:28]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[agrieve, 2015-11-24 14:45:16]

The CQ bit was checked by agrieve@chromium.org

[commit-bot: I haz the power, 2015-11-24 14:46:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1469143002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1469143002/20001

[commit-bot: I haz the power, 2015-11-24 15:23:30]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-11-24 15:24:27]

Patchset 2 (id:??) landed as
https://crrev.com/d7c8cc052f46bc38cb7eb5fafda396b8c2e3cd0c
Cr-Commit-Position: refs/heads/master@{#361343}