Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1020)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1397423005: GN: Fix enable_incremental_javac never recompiling changes to .srcjars (Closed)

Created:
5 years, 2 months ago by agrieve
Modified:
5 years, 2 months ago
Reviewers:
newt (away)
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN: Fix enable_incremental_javac never recompiling changes to .srcjars BUG=542927 Committed: https://crrev.com/331fc155dc3e4f9afa1c1219c671248de037f1b7 Cr-Commit-Position: refs/heads/master@{#354012}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M build/android/gyp/javac.py View 1 chunk +2 lines, -1 line 0 comments Download

Depends on Patchset:

Issue 1217063002 Patch 1

Messages

Total messages: 11 (4 generated)
agrieve
On 2015/10/14 02:47:39, agrieve wrote: > mailto:agrieve@chromium.org changed reviewers: > + mailto:newt@chromium.org
5 years, 2 months ago (2015-10-14 02:47:45 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1397423005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1397423005/1
5 years, 2 months ago (2015-10-14 02:49:04 UTC) #4
newt (away)
lgtm. Thanks for the quick fix!
5 years, 2 months ago (2015-10-14 03:29:01 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-14 04:08:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1397423005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1397423005/1
5 years, 2 months ago (2015-10-14 13:33:33 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-14 13:38:48 UTC) #10
commit-bot: I haz the power
5 years, 2 months ago (2015-10-14 13:39:39 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/331fc155dc3e4f9afa1c1219c671248de037f1b7
Cr-Commit-Position: refs/heads/master@{#354012}

Powered by Google App Engine
This is Rietveld 408576698