Fix device_utils.SetProp not properly clearing cached value

Fix device_utils.SetProp not properly clearing cached value

BUG=

Committed: https://crrev.com/f15b1d8302972959de4d69047fc13fef9a7d0fec
Cr-Commit-Position: refs/heads/master@{#342825}

[agrieve, 2015-08-11 00:42:48]

agrieve@chromium.org changed reviewers:
+ jbudorick@chromium.org

[agrieve, 2015-08-11 00:42:49]

Wasn't causing a problem, just stumbled upon it when reading code

[jbudorick, 2015-08-11 00:47:54]

lgtm w/ optional nit

Also, this is awesome.

https://codereview.chromium.org/1275263004/diff/1/build/android/pylib/device/...
File build/android/pylib/device/device_utils.py (right):

https://codereview.chromium.org/1275263004/diff/1/build/android/pylib/device/...
build/android/pylib/device/device_utils.py:1561: cache_key = '_prop:' +
property_name
optional nit: wdyt about a _PropertyCacheKey function here and up in GetProp?

[agrieve, 2015-08-11 13:51:56]

https://codereview.chromium.org/1275263004/diff/1/build/android/pylib/device/...
File build/android/pylib/device/device_utils.py (right):

https://codereview.chromium.org/1275263004/diff/1/build/android/pylib/device/...
build/android/pylib/device/device_utils.py:1561: cache_key = '_prop:' +
property_name
On 2015/08/11 00:47:54, jbudorick wrote:
> optional nit: wdyt about a _PropertyCacheKey function here and up in GetProp?

If we're going to go with having sub-caches for APK checksums, then it might
make more sense to have this in its own namespace as well:
self._cache['props'][property_name].

Will just leave as-is for now.

[agrieve, 2015-08-11 13:52:09]

The CQ bit was checked by agrieve@chromium.org

[commit-bot: I haz the power, 2015-08-11 13:52:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1275263004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1275263004/1

[jbudorick, 2015-08-11 13:53:18]

https://codereview.chromium.org/1275263004/diff/1/build/android/pylib/device/...
File build/android/pylib/device/device_utils.py (right):

https://codereview.chromium.org/1275263004/diff/1/build/android/pylib/device/...
build/android/pylib/device/device_utils.py:1561: cache_key = '_prop:' +
property_name
On 2015/08/11 at 13:51:56, agrieve wrote:
> On 2015/08/11 00:47:54, jbudorick wrote:
> > optional nit: wdyt about a _PropertyCacheKey function here and up in
GetProp?
> 
> If we're going to go with having sub-caches for APK checksums, then it might
make more sense to have this in its own namespace as well:
self._cache['props'][property_name].

Hmm, good point.

> 
> Will just leave as-is for now.

sgtm

[commit-bot: I haz the power, 2015-08-11 15:59:33]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-08-11 16:00:05]

Patchset 1 (id:??) landed as
https://crrev.com/f15b1d8302972959de4d69047fc13fef9a7d0fec
Cr-Commit-Position: refs/heads/master@{#342825}